You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openmeetings.apache.org by vd...@apache.org on 2013/10/24 11:13:06 UTC
svn commit: r1535321 - in /openmeetings:
branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
Author: vdegtyarev
Date: Thu Oct 24 09:13:06 2013
New Revision: 1535321
URL: http://svn.apache.org/r1535321
Log:
OPENMEETINGS-819 minor changes. Hide zoom bar for non moderator users on whiteboard.
Modified:
openmeetings/branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
openmeetings/trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
Modified: openmeetings/branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
URL: http://svn.apache.org/viewvc/openmeetings/branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx?rev=1535321&r1=1535320&r2=1535321&view=diff
==============================================================================
--- openmeetings/branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx (original)
+++ openmeetings/branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx Thu Oct 24 09:13:06 2013
@@ -535,7 +535,8 @@
this.ignoreUpdates = false;
</method>
- <labelCheckbox x="344" name="_fullFit" labelid="847" y="4" fontstyle="bold" bgcolor="0xFFFFFF" >
+ <labelCheckbox x="344" name="_fullFit" labelid="847" y="4" fontstyle="bold" bgcolor="0xFFFFFF"
+ visible="${ ((canvas.becomemoderator) ? true : false ) }">
<handler name="onvalue" args="v">
if (parent.ignoreUpdates) {
return;
@@ -548,7 +549,8 @@
</labelCheckbox>
<changeWidthSlider name="_zoom" initialNumberInit="50"
- boxPosition="down" initialNumber="50" maximum="200">
+ boxPosition="down" initialNumber="50" maximum="200"
+ visible="${ ((canvas.becomemoderator) ? true : false ) }">
<handler name="oninitialNumber" args="i">
if (parent.ignoreUpdates) {
return;
Modified: openmeetings/trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
URL: http://svn.apache.org/viewvc/openmeetings/trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx?rev=1535321&r1=1535320&r2=1535321&view=diff
==============================================================================
--- openmeetings/trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx (original)
+++ openmeetings/trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx Thu Oct 24 09:13:06 2013
@@ -539,7 +539,8 @@
this.ignoreUpdates = false;
</method>
- <labelCheckbox x="344" name="_fullFit" labelid="847" y="4" fontstyle="bold" bgcolor="0xFFFFFF" >
+ <labelCheckbox x="344" name="_fullFit" labelid="847" y="4" fontstyle="bold" bgcolor="0xFFFFFF"
+ visible="${ ((canvas.becomemoderator) ? true : false ) }">
<handler name="onvalue" args="v">
if (parent.ignoreUpdates) {
return;
@@ -554,7 +555,8 @@
</labelCheckbox>
<changeWidthSlider name="_zoom" initialNumberInit="50" labelid="1328"
- boxPosition="down" initialNumber="50" maximum="200">
+ boxPosition="down" initialNumber="50" maximum="200"
+ visible="${ ((canvas.becomemoderator) ? true : false ) }">
<handler name="oninitialNumber" args="i">
if (parent.ignoreUpdates) {
return;
Re: svn commit: r1535321 - in /openmeetings: branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
Posted by "seba.wagner@gmail.com" <se...@gmail.com>.
Okay,
thanks for verifying that Vasiliy!
Just to give you some more "historical" context of this functionality:
1) We had this group of people complaining about participants being able to
zoom because the moderator gets annoyed.
Probably this is fixed by now and we have a common understanding of it.
2) There is this screen resolution problem. So that is why we added this
"full-fit" button. Cause for the most of the time people upload documents
and show them on the whiteoard. But often it happens that the moderator has
a screen resolution of 1680x1280 and the visitors are in front of some old
1024x768 monitor.
What the full fit does is, that its simply scales to whatever shows the
complete document in the whiteboard. And adjusts the zoom automatically.
Even when resizing the window. So it can be 68% on one screen and on the
other 78%.
I think that made a fair amount of people happy. Complaints dropped.
3) But now the next complaints were raised that some participants just want
to control their screen and adjust it their way.
This is when we made the zoom and whiteboard position visible to everybody
to adjust. But only the moderator events are synchronized, not the
participants.
So, problably the solution for use-case 3) is open for discussion. I
generally see this as an open discussion. We should probably just try to
discuss more.
Sebastian
2013/10/24 Vasiliy Degtyarev <va...@unipro.ru>
> Hello Sebastian,
>
> I have tested and found that the zoom event is not sending when re-size
> the browser window.
>
> Vasiliy.
>
>
>
> On 24.10.2013 16:25, seba.wagner@gmail.com wrote:
>
> Hi Vasya,
>
> Thanks for adding that.
>
> The other issue in the past was that not only the zoombar sends that event
> when you actively zoom. The zoom might change when you resize the browser
> window. Or maximise the window.
> So I am not really sure if hiding the ui tool does really prevent sending
> the event from non moderators to everybody else.
>
> Sebastian
> On 24 Oct 2013 22:13, <vd...@apache.org> wrote:
>
>> Author: vdegtyarev
>> Date: Thu Oct 24 09:13:06 2013
>> New Revision: 1535321
>>
>> URL: http://svn.apache.org/r1535321
>> Log:
>> OPENMEETINGS-819 minor changes. Hide zoom bar for non moderator users on
>> whiteboard.
>>
>> Modified:
>>
>> openmeetings/branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
>>
>> openmeetings/trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
>>
>> Modified:
>> openmeetings/branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
>> URL:
>> http://svn.apache.org/viewvc/openmeetings/branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx?rev=1535321&r1=1535320&r2=1535321&view=diff
>>
>> ==============================================================================
>> ---
>> openmeetings/branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
>> (original)
>> +++
>> openmeetings/branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
>> Thu Oct 24 09:13:06 2013
>> @@ -535,7 +535,8 @@
>> this.ignoreUpdates = false;
>> </method>
>>
>> - <labelCheckbox x="344" name="_fullFit" labelid="847" y="4"
>> fontstyle="bold" bgcolor="0xFFFFFF" >
>> + <labelCheckbox x="344" name="_fullFit" labelid="847" y="4"
>> fontstyle="bold" bgcolor="0xFFFFFF"
>> + visible="${ ((canvas.becomemoderator) ? true :
>> false ) }">
>> <handler name="onvalue" args="v">
>> if (parent.ignoreUpdates) {
>> return;
>> @@ -548,7 +549,8 @@
>> </labelCheckbox>
>>
>> <changeWidthSlider name="_zoom" initialNumberInit="50"
>> - boxPosition="down" initialNumber="50" maximum="200">
>> + boxPosition="down" initialNumber="50" maximum="200"
>> + visible="${ ((canvas.becomemoderator) ? true : false ) }">
>> <handler name="oninitialNumber" args="i">
>> if (parent.ignoreUpdates) {
>> return;
>>
>> Modified:
>> openmeetings/trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
>> URL:
>> http://svn.apache.org/viewvc/openmeetings/trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx?rev=1535321&r1=1535320&r2=1535321&view=diff
>>
>> ==============================================================================
>> ---
>> openmeetings/trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
>> (original)
>> +++
>> openmeetings/trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
>> Thu Oct 24 09:13:06 2013
>> @@ -539,7 +539,8 @@
>> this.ignoreUpdates = false;
>> </method>
>>
>> - <labelCheckbox x="344" name="_fullFit" labelid="847" y="4"
>> fontstyle="bold" bgcolor="0xFFFFFF" >
>> + <labelCheckbox x="344" name="_fullFit" labelid="847" y="4"
>> fontstyle="bold" bgcolor="0xFFFFFF"
>> + visible="${ ((canvas.becomemoderator) ? true :
>> false ) }">
>> <handler name="onvalue" args="v">
>> if (parent.ignoreUpdates) {
>> return;
>> @@ -554,7 +555,8 @@
>> </labelCheckbox>
>>
>> <changeWidthSlider name="_zoom" initialNumberInit="50"
>> labelid="1328"
>> - boxPosition="down" initialNumber="50" maximum="200">
>> + boxPosition="down" initialNumber="50" maximum="200"
>> + visible="${ ((canvas.becomemoderator) ? true :
>> false ) }">
>> <handler name="oninitialNumber" args="i">
>> if (parent.ignoreUpdates) {
>> return;
>>
>>
>>
>
--
Sebastian Wagner
https://twitter.com/#!/dead_lock
http://www.webbase-design.de
http://www.wagner-sebastian.com
seba.wagner@gmail.com
Re: svn commit: r1535321 - in /openmeetings: branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
Posted by Vasiliy Degtyarev <va...@unipro.ru>.
Hello Sebastian,
I have tested and found that the zoom event is not sending when re-size
the browser window.
Vasiliy.
On 24.10.2013 16:25, seba.wagner@gmail.com wrote:
>
> Hi Vasya,
>
> Thanks for adding that.
>
> The other issue in the past was that not only the zoombar sends that
> event when you actively zoom. The zoom might change when you resize
> the browser window. Or maximise the window.
> So I am not really sure if hiding the ui tool does really prevent
> sending the event from non moderators to everybody else.
>
> Sebastian
>
> On 24 Oct 2013 22:13, <vdegtyarev@apache.org
> <ma...@apache.org>> wrote:
>
> Author: vdegtyarev
> Date: Thu Oct 24 09:13:06 2013
> New Revision: 1535321
>
> URL: http://svn.apache.org/r1535321
> Log:
> OPENMEETINGS-819 minor changes. Hide zoom bar for non moderator
> users on whiteboard.
>
> Modified:
> openmeetings/branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
> openmeetings/trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
>
> Modified:
> openmeetings/branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
> URL:
> http://svn.apache.org/viewvc/openmeetings/branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx?rev=1535321&r1=1535320&r2=1535321&view=diff
> ==============================================================================
> ---
> openmeetings/branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
> (original)
> +++
> openmeetings/branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
> Thu Oct 24 09:13:06 2013
> @@ -535,7 +535,8 @@
> this.ignoreUpdates = false;
> </method>
>
> - <labelCheckbox x="344" name="_fullFit" labelid="847"
> y="4" fontstyle="bold" bgcolor="0xFFFFFF" >
> + <labelCheckbox x="344" name="_fullFit" labelid="847"
> y="4" fontstyle="bold" bgcolor="0xFFFFFF"
> + visible="${ ((canvas.becomemoderator) ?
> true : false ) }">
> <handler name="onvalue" args="v">
> if (parent.ignoreUpdates) {
> return;
> @@ -548,7 +549,8 @@
> </labelCheckbox>
>
> <changeWidthSlider name="_zoom" initialNumberInit="50"
> - boxPosition="down" initialNumber="50" maximum="200">
> + boxPosition="down" initialNumber="50" maximum="200"
> + visible="${ ((canvas.becomemoderator) ? true :
> false ) }">
> <handler name="oninitialNumber" args="i">
> if (parent.ignoreUpdates) {
> return;
>
> Modified:
> openmeetings/trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
> URL:
> http://svn.apache.org/viewvc/openmeetings/trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx?rev=1535321&r1=1535320&r2=1535321&view=diff
> ==============================================================================
> ---
> openmeetings/trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
> (original)
> +++
> openmeetings/trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
> Thu Oct 24 09:13:06 2013
> @@ -539,7 +539,8 @@
> this.ignoreUpdates = false;
> </method>
>
> - <labelCheckbox x="344" name="_fullFit" labelid="847"
> y="4" fontstyle="bold" bgcolor="0xFFFFFF" >
> + <labelCheckbox x="344" name="_fullFit" labelid="847"
> y="4" fontstyle="bold" bgcolor="0xFFFFFF"
> + visible="${ ((canvas.becomemoderator) ?
> true : false ) }">
> <handler name="onvalue" args="v">
> if (parent.ignoreUpdates) {
> return;
> @@ -554,7 +555,8 @@
> </labelCheckbox>
>
> <changeWidthSlider name="_zoom" initialNumberInit="50"
> labelid="1328"
> - boxPosition="down" initialNumber="50" maximum="200">
> + boxPosition="down" initialNumber="50"
> maximum="200"
> + visible="${ ((canvas.becomemoderator) ?
> true : false ) }">
> <handler name="oninitialNumber" args="i">
> if (parent.ignoreUpdates) {
> return;
>
>
Re: svn commit: r1535321 - in /openmeetings: branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
Posted by "seba.wagner@gmail.com" <se...@gmail.com>.
Hi Vasya,
Thanks for adding that.
The other issue in the past was that not only the zoombar sends that event
when you actively zoom. The zoom might change when you resize the browser
window. Or maximise the window.
So I am not really sure if hiding the ui tool does really prevent sending
the event from non moderators to everybody else.
Sebastian
On 24 Oct 2013 22:13, <vd...@apache.org> wrote:
> Author: vdegtyarev
> Date: Thu Oct 24 09:13:06 2013
> New Revision: 1535321
>
> URL: http://svn.apache.org/r1535321
> Log:
> OPENMEETINGS-819 minor changes. Hide zoom bar for non moderator users on
> whiteboard.
>
> Modified:
>
> openmeetings/branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
>
> openmeetings/trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
>
> Modified:
> openmeetings/branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
> URL:
> http://svn.apache.org/viewvc/openmeetings/branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx?rev=1535321&r1=1535320&r2=1535321&view=diff
>
> ==============================================================================
> ---
> openmeetings/branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
> (original)
> +++
> openmeetings/branches/2.x/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
> Thu Oct 24 09:13:06 2013
> @@ -535,7 +535,8 @@
> this.ignoreUpdates = false;
> </method>
>
> - <labelCheckbox x="344" name="_fullFit" labelid="847" y="4"
> fontstyle="bold" bgcolor="0xFFFFFF" >
> + <labelCheckbox x="344" name="_fullFit" labelid="847" y="4"
> fontstyle="bold" bgcolor="0xFFFFFF"
> + visible="${ ((canvas.becomemoderator) ? true :
> false ) }">
> <handler name="onvalue" args="v">
> if (parent.ignoreUpdates) {
> return;
> @@ -548,7 +549,8 @@
> </labelCheckbox>
>
> <changeWidthSlider name="_zoom" initialNumberInit="50"
> - boxPosition="down" initialNumber="50" maximum="200">
> + boxPosition="down" initialNumber="50" maximum="200"
> + visible="${ ((canvas.becomemoderator) ? true : false ) }">
> <handler name="oninitialNumber" args="i">
> if (parent.ignoreUpdates) {
> return;
>
> Modified:
> openmeetings/trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
> URL:
> http://svn.apache.org/viewvc/openmeetings/trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx?rev=1535321&r1=1535320&r2=1535321&view=diff
>
> ==============================================================================
> ---
> openmeetings/trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
> (original)
> +++
> openmeetings/trunk/singlewebapp/WebContent/src/modules/conference/whiteboard/fixedFileExplorerWhiteBoard.lzx
> Thu Oct 24 09:13:06 2013
> @@ -539,7 +539,8 @@
> this.ignoreUpdates = false;
> </method>
>
> - <labelCheckbox x="344" name="_fullFit" labelid="847" y="4"
> fontstyle="bold" bgcolor="0xFFFFFF" >
> + <labelCheckbox x="344" name="_fullFit" labelid="847" y="4"
> fontstyle="bold" bgcolor="0xFFFFFF"
> + visible="${ ((canvas.becomemoderator) ? true :
> false ) }">
> <handler name="onvalue" args="v">
> if (parent.ignoreUpdates) {
> return;
> @@ -554,7 +555,8 @@
> </labelCheckbox>
>
> <changeWidthSlider name="_zoom" initialNumberInit="50"
> labelid="1328"
> - boxPosition="down" initialNumber="50" maximum="200">
> + boxPosition="down" initialNumber="50" maximum="200"
> + visible="${ ((canvas.becomemoderator) ? true :
> false ) }">
> <handler name="oninitialNumber" args="i">
> if (parent.ignoreUpdates) {
> return;
>
>
>