You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2008/07/22 10:37:28 UTC
DO NOT REPLY [Bug 45451] New: Tag file attribute evaluation
https://issues.apache.org/bugzilla/show_bug.cgi?id=45451
Summary: Tag file attribute evaluation
Product: Tomcat 6
Version: 6.0.16
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: normal
Priority: P2
Component: Jasper
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: herve@instranet.com
Hello,
I have an web app with 2 tag files.
Here is my first tag 'testtag':
<%@ tag %>
<%@ attribute name="onLoad" %>
<%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %>
<c:if test="${! empty onLoad}">
<input type="hidden" name="OnLoadParameter" value="${onLoad}" />
</c:if>
My second tag ('testtag2') use the first one:
<%@ tag %>
<%@ attribute name="name" %>
<%@ taglib prefix="widget" tagdir="/WEB-INF/tags/widgets" %>
<widget:testtag onLoad="{Script:'jsFunction(\\\'${name}\\\')'}" />
In a JSP, I use the second tag:
...
<%@ taglib prefix="widget" tagdir="/WEB-INF/tags/widgets" %>
...
<widget:testtag2 name="toto" />
...
With tomcat 5.5.25, I have the following result:
<input type="hidden" name="OnLoadParameter"
value="{Script:'jsFunction(\'toto\')'}" />
And with tomcat 6.0.16:
<input type="hidden" name="OnLoadParameter"
value="{Script:'jsFunction('toto')'}" />
It seems that the attribute is evaluate once more on tomcat 6 than on tomcat 5.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 45451] Tag file attribute evaluation
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45451
--- Comment #2 from Mark Thomas <ma...@apache.org> 2008-09-16 14:14:55 PST ---
I have committed a fix for this to trunk and proposed it for 6.0.x. The patch
also includes various fixes around handling \${...}
Any testing you can do would be appreciated.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 45451] Tag file attribute evaluation
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45451
--- Comment #1 from ilango <il...@yahoo.com> 2008-08-10 09:35:44 PST ---
(In reply to comment #0)
> Hello,
> I have an web app with 2 tag files.
> Here is my first tag 'testtag':
>
> <%@ tag %>
> <%@ attribute name="onLoad" %>
> <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %>
>
> <c:if test="${! empty onLoad}">
> <input type="hidden" name="OnLoadParameter" value="${onLoad}" />
> </c:if>
>
> My second tag ('testtag2') use the first one:
>
> <%@ tag %>
> <%@ attribute name="name" %>
> <%@ taglib prefix="widget" tagdir="/WEB-INF/tags/widgets" %>
>
> <widget:testtag onLoad="{Script:'jsFunction(\\\'${name}\\\')'}" />
>
>
> In a JSP, I use the second tag:
>
> ...
> <%@ taglib prefix="widget" tagdir="/WEB-INF/tags/widgets" %>
> ...
> <widget:testtag2 name="toto" />
> ...
>
>
> With tomcat 5.5.25, I have the following result:
> <input type="hidden" name="OnLoadParameter"
> value="{Script:'jsFunction(\'toto\')'}" />
>
> And with tomcat 6.0.16:
> <input type="hidden" name="OnLoadParameter"
> value="{Script:'jsFunction('toto')'}" />
>
> It seems that the attribute is evaluate once more on tomcat 6 than on tomcat 5.
>
I would like to test this behaviour. Do you have a simple test case?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 45451] Tag file attribute evaluation
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45451
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #3 from Mark Thomas <ma...@apache.org> 2008-10-27 06:34:52 PST ---
The final fix for this got caught up in a spec query
(http://markmail.org/message/2rq3vkvx76vmhq75). This has been resolved and the
fix has now been applied to 6.0.x. It will be in 6.0.19 onwards.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org