You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2016/09/01 06:25:06 UTC

[GitHub] zeppelin pull request #1391: ZEPPELIN-1403. Should maintain the using port l...

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/1391

    ZEPPELIN-1403. Should maintain the using port list

    ### What is this PR for?
    For now, in RemoteInterpreterManagedProcess we will first find one available port (By using ServerSocket) and then use this port in the interpreter process. But it is possible that 2 interpreters use the same port. Here's the scenarios.
    1. Thread1 (Interpreter A) find available port 3000 
    2. Thread2 (Interpreter B) find available port 3000 
    3. Process for Interpreter A starts
    4. Process for Interpreter B starts
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-1403
    
    ### How should this be tested?
    No test added
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1403

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1391.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1391
    
----
commit 8ce0c5fb5b94aa9d8efb0ee0f9f32d0e629b3ba6
Author: Jeff Zhang <zj...@apache.org>
Date:   2016-09-01T06:21:56Z

    ZEPPELIN-1403. Should maintain the using port list

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1391: ZEPPELIN-1403. Should maintain the using port list

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/1391
  
    @bzz Sorry for delay, I was in vacation in the last 2 weeks. Regarding move it to other places rather than static, I am thinking to use a PortProvider class to wrap all the logic and of course this class should be singleton. What do you think ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1391: ZEPPELIN-1403. Should maintain the using port l...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu closed the pull request at:

    https://github.com/apache/zeppelin/pull/1391


---

[GitHub] zeppelin issue #1391: ZEPPELIN-1403. Should maintain the using port list

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1391
  
    @zjffdu test plan sounds great. 
    
    My only concern was - may we can find a better place for this state, rather than `static` ? Move it somewhere, where if does not require to be static, but can be an instance method\state


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1391: ZEPPELIN-1403. Should maintain the using port list

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1391
  
    Having a `PortProvider` as injectable dependency, that incapsulates all the logic about picking the port numbers sounds great!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---