You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "Rainer Jung (JIRA)" <ji...@apache.org> on 2008/11/14 20:49:44 UTC
[jira] Created: (OPENEJB-956) Installation of Java Agent fails when
used with Tomcat and CATALINA_HOME != CATALINA_BASE
Installation of Java Agent fails when used with Tomcat and CATALINA_HOME != CATALINA_BASE
-----------------------------------------------------------------------------------------
Key: OPENEJB-956
URL: https://issues.apache.org/jira/browse/OPENEJB-956
Project: OpenEJB
Issue Type: Bug
Components: tomcat
Affects Versions: 3.1
Environment: All
Reporter: Rainer Jung
Priority: Minor
The war installer for using openejb in Tomcat installs the java agent into CATALINA_HOME/lib.
Then it patches catalina.sh and catalina.bat to add a -javaagent parameter during startup. That code erroneously assumes the agent was installed into CATALINA_BASE (instead of CATALINA_HOME). If both are the same that's fine, if not, it breaks.
I attach the simple patch.
Note: Installing into CATALINA_BASE might actually be nicer, but CATALINA_BASE/lib is not on the default search path of the Tomcat loaders, so one would also have to patch common.loader in CATALINA_BASE/conf/catalina.properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENEJB-956) Installation of Java Agent fails when
used with Tomcat and CATALINA_HOME != CATALINA_BASE
Posted by "David Blevins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Blevins updated OPENEJB-956:
----------------------------------
Fix Version/s: 3.1.1
> Installation of Java Agent fails when used with Tomcat and CATALINA_HOME != CATALINA_BASE
> -----------------------------------------------------------------------------------------
>
> Key: OPENEJB-956
> URL: https://issues.apache.org/jira/browse/OPENEJB-956
> Project: OpenEJB
> Issue Type: Bug
> Components: tomcat
> Affects Versions: 3.1
> Environment: All
> Reporter: Rainer Jung
> Assignee: Jonathan Gallimore
> Priority: Minor
> Fix For: 3.1.1
>
> Attachments: openejb.patch
>
>
> The war installer for using openejb in Tomcat installs the java agent into CATALINA_HOME/lib.
> Then it patches catalina.sh and catalina.bat to add a -javaagent parameter during startup. That code erroneously assumes the agent was installed into CATALINA_BASE (instead of CATALINA_HOME). If both are the same that's fine, if not, it breaks.
> I attach the simple patch.
> Note: Installing into CATALINA_BASE might actually be nicer, but CATALINA_BASE/lib is not on the default search path of the Tomcat loaders, so one would also have to patch common.loader in CATALINA_BASE/conf/catalina.properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OPENEJB-956) Installation of Java Agent fails
when used with Tomcat and CATALINA_HOME != CATALINA_BASE
Posted by "Jonathan Gallimore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gallimore reassigned OPENEJB-956:
------------------------------------------
Assignee: Jonathan Gallimore
> Installation of Java Agent fails when used with Tomcat and CATALINA_HOME != CATALINA_BASE
> -----------------------------------------------------------------------------------------
>
> Key: OPENEJB-956
> URL: https://issues.apache.org/jira/browse/OPENEJB-956
> Project: OpenEJB
> Issue Type: Bug
> Components: tomcat
> Affects Versions: 3.1
> Environment: All
> Reporter: Rainer Jung
> Assignee: Jonathan Gallimore
> Priority: Minor
> Attachments: openejb.patch
>
>
> The war installer for using openejb in Tomcat installs the java agent into CATALINA_HOME/lib.
> Then it patches catalina.sh and catalina.bat to add a -javaagent parameter during startup. That code erroneously assumes the agent was installed into CATALINA_BASE (instead of CATALINA_HOME). If both are the same that's fine, if not, it breaks.
> I attach the simple patch.
> Note: Installing into CATALINA_BASE might actually be nicer, but CATALINA_BASE/lib is not on the default search path of the Tomcat loaders, so one would also have to patch common.loader in CATALINA_BASE/conf/catalina.properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENEJB-956) Installation of Java Agent fails
when used with Tomcat and CATALINA_HOME != CATALINA_BASE
Posted by "Jonathan Gallimore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649199#action_12649199 ]
Jonathan Gallimore commented on OPENEJB-956:
--------------------------------------------
Many thanks for the patch, I've committed it (r719114).
> Installation of Java Agent fails when used with Tomcat and CATALINA_HOME != CATALINA_BASE
> -----------------------------------------------------------------------------------------
>
> Key: OPENEJB-956
> URL: https://issues.apache.org/jira/browse/OPENEJB-956
> Project: OpenEJB
> Issue Type: Bug
> Components: tomcat
> Affects Versions: 3.1
> Environment: All
> Reporter: Rainer Jung
> Assignee: Jonathan Gallimore
> Priority: Minor
> Attachments: openejb.patch
>
>
> The war installer for using openejb in Tomcat installs the java agent into CATALINA_HOME/lib.
> Then it patches catalina.sh and catalina.bat to add a -javaagent parameter during startup. That code erroneously assumes the agent was installed into CATALINA_BASE (instead of CATALINA_HOME). If both are the same that's fine, if not, it breaks.
> I attach the simple patch.
> Note: Installing into CATALINA_BASE might actually be nicer, but CATALINA_BASE/lib is not on the default search path of the Tomcat loaders, so one would also have to patch common.loader in CATALINA_BASE/conf/catalina.properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OPENEJB-956) Installation of Java Agent fails when
used with Tomcat and CATALINA_HOME != CATALINA_BASE
Posted by "Jonathan Gallimore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gallimore closed OPENEJB-956.
--------------------------------------
Resolution: Fixed
Committed in r719114
> Installation of Java Agent fails when used with Tomcat and CATALINA_HOME != CATALINA_BASE
> -----------------------------------------------------------------------------------------
>
> Key: OPENEJB-956
> URL: https://issues.apache.org/jira/browse/OPENEJB-956
> Project: OpenEJB
> Issue Type: Bug
> Components: tomcat
> Affects Versions: 3.1
> Environment: All
> Reporter: Rainer Jung
> Assignee: Jonathan Gallimore
> Priority: Minor
> Attachments: openejb.patch
>
>
> The war installer for using openejb in Tomcat installs the java agent into CATALINA_HOME/lib.
> Then it patches catalina.sh and catalina.bat to add a -javaagent parameter during startup. That code erroneously assumes the agent was installed into CATALINA_BASE (instead of CATALINA_HOME). If both are the same that's fine, if not, it breaks.
> I attach the simple patch.
> Note: Installing into CATALINA_BASE might actually be nicer, but CATALINA_BASE/lib is not on the default search path of the Tomcat loaders, so one would also have to patch common.loader in CATALINA_BASE/conf/catalina.properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENEJB-956) Installation of Java Agent fails when
used with Tomcat and CATALINA_HOME != CATALINA_BASE
Posted by "Rainer Jung (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rainer Jung updated OPENEJB-956:
--------------------------------
Attachment: openejb.patch
Patch
> Installation of Java Agent fails when used with Tomcat and CATALINA_HOME != CATALINA_BASE
> -----------------------------------------------------------------------------------------
>
> Key: OPENEJB-956
> URL: https://issues.apache.org/jira/browse/OPENEJB-956
> Project: OpenEJB
> Issue Type: Bug
> Components: tomcat
> Affects Versions: 3.1
> Environment: All
> Reporter: Rainer Jung
> Priority: Minor
> Attachments: openejb.patch
>
>
> The war installer for using openejb in Tomcat installs the java agent into CATALINA_HOME/lib.
> Then it patches catalina.sh and catalina.bat to add a -javaagent parameter during startup. That code erroneously assumes the agent was installed into CATALINA_BASE (instead of CATALINA_HOME). If both are the same that's fine, if not, it breaks.
> I attach the simple patch.
> Note: Installing into CATALINA_BASE might actually be nicer, but CATALINA_BASE/lib is not on the default search path of the Tomcat loaders, so one would also have to patch common.loader in CATALINA_BASE/conf/catalina.properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.