[jira] [Commented] (YARN-9097) Investigate why GpuDiscoverer methods are synchronized

["Bilwa S T (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-9097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123963#comment-17123963 ] 

Bilwa S T commented on YARN-9097:
---------------------------------

Hi [~snemeth]
Thanks for raising this issue. I could see that getGpuDeviceInformation is called on NM init and GpuResourcePlugin#getNMResourceInfo which is already synchronized and getGpusUsableByYarn is also called on NM init. Hence all three methods need not be synchronized
I think even GpuResourceHandlerImpl#postComplete need not be synchronized as GpuResourceAllocator#unassignGpus is already synchronized

> Investigate why GpuDiscoverer methods are synchronized
> ------------------------------------------------------
>
>                 Key: YARN-9097
>                 URL: https://issues.apache.org/jira/browse/YARN-9097
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Bilwa S T
>            Priority: Minor
>              Labels: newbie, newbie++
>
> GpuDiscoverer.initialize surely shouldn't have been synchronized.
> Please also investigate why getGpuDeviceInformation / getGpusUsableByYarn are synchronized.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org