You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:55:12 UTC

[GitHub] [incubator-apisix-dashboard] Rapiz1 opened a new issue #340: Lint failed on source

Rapiz1 opened a new issue #340:
URL: https://github.com/apache/incubator-apisix-dashboard/issues/340


   We should fix these issues before any attempt to set up a linter on Actions.
   ```
   yarn run v1.22.4
   warning package.json: "dependencies" has dependency "react-helmet-async" with range "^1.0.4" that collides with a dependency in "devDependencies" of the same name with version "1.0.6"
   $ umi g tmp && npm run lint:js && npm run lint:style && npm run lint:prettier
   npm WARN lifecycle The node binary used for scripts is /tmp/yarn--1595906147339-0.5859369794624159/node but npm is using /usr/bin/node itself. Use the `--scripts-prepend-node-path` option to include the path for the node binary npm was executed with.
   
   > apisix-dashboard@1.1.0 lint:js /project/incubator-apisix-dashboard
   > eslint --cache --ext .js,.jsx,.ts,.tsx --format=pretty ./src
   
   
     src/access.ts:1:16
     ⚠    1:16  Unexpected unnamed function.                                                                                func-names
   
     src/pages/Route/transform.ts:11:9
     ✖   11:9   Variable name upstream_header must match one of the following formats: camelCase, PascalCase, UPPER_CASE    @typescript-eslint/naming-convention
     ✖  150:5   Variable name upstream_path must match one of the following formats: camelCase, PascalCase, UPPER_CASE      @typescript-eslint/naming-convention
     ✖  151:5   Variable name upstream_header must match one of the following formats: camelCase, PascalCase, UPPER_CASE    @typescript-eslint/naming-convention
     ✖  152:5   Variable name upstream_protocol must match one of the following formats: camelCase, PascalCase, UPPER_CASE  @typescript-eslint/naming-convention
     ✖  153:5   Variable name upstream_id must match one of the following formats: camelCase, PascalCase, UPPER_CASE        @typescript-eslint/naming-convention
   
     src/pages/SSL/service.ts:9:10
     ✖    9:10  Variable name expire_start must match one of the following formats: camelCase, PascalCase, UPPER_CASE       @typescript-eslint/naming-convention
     ✖    9:24  Variable name expire_end must match one of the following formats: camelCase, PascalCase, UPPER_CASE         @typescript-eslint/naming-convention
     ✖   12:5   Use an object spread instead of Object.assign eg: { ...foo }.                                               prefer-object-spread
   
     src/pages/Upstream/Create.tsx:6:25
     ✖    6:25  /project/incubator-apisix-dashboard/node_modules/umi/index.js imported multiple times.       import/no-duplicates
     ✖    7:25  /project/incubator-apisix-dashboard/node_modules/umi/index.js imported multiple times.       import/no-duplicates
     ✖   33:39  Unexpected string concatenation.                                                                            prefer-template
   
     src/components/PluginPage/PluginPage.tsx:104:25
     ✖  104:25  Use an object spread instead of Object.assign eg: { ...foo }.                                               prefer-object-spread
     ✖  117:20  Use an object spread instead of Object.assign eg: { ...foo }.                                               prefer-object-spread
   
     src/pages/Consumer/Create.tsx:4:25
     ✖    4:25  /project/incubator-apisix-dashboard/node_modules/umi/index.js imported multiple times.       import/no-duplicates
     ✖    5:25  /project/incubator-apisix-dashboard/node_modules/umi/index.js imported multiple times.       import/no-duplicates
   
     src/pages/Consumer/List.tsx:8:25
     ✖    8:25  /project/incubator-apisix-dashboard/node_modules/umi/index.js imported multiple times.       import/no-duplicates
     ✖    9:25  /project/incubator-apisix-dashboard/node_modules/umi/index.js imported multiple times.       import/no-duplicates
   
     src/pages/Route/List.tsx:7:25
     ✖    7:25  /project/incubator-apisix-dashboard/node_modules/umi/index.js imported multiple times.       import/no-duplicates
     ✖    8:25  /project/incubator-apisix-dashboard/node_modules/umi/index.js imported multiple times.       import/no-duplicates
   
     src/pages/SSL/Create.tsx:5:25
     ✖    5:25  /project/incubator-apisix-dashboard/node_modules/umi/index.js imported multiple times.       import/no-duplicates
     ✖    8:25  /project/incubator-apisix-dashboard/node_modules/umi/index.js imported multiple times.       import/no-duplicates
   
     src/pages/Upstream/List.tsx:6:25
     ✖    6:25  /project/incubator-apisix-dashboard/node_modules/umi/index.js imported multiple times.       import/no-duplicates
     ✖    7:25  /project/incubator-apisix-dashboard/node_modules/umi/index.js imported multiple times.       import/no-duplicates
   
     src/components/PluginForm/locales/en-US.ts:72:62
     ✖   72:62  Unexpected template string expression.                                                                      no-template-curly-in-string
   
     src/components/PluginForm/locales/zh-CN.ts:72:62
     ✖   72:62  Unexpected template string expression.                                                                      no-template-curly-in-string
   
     1 warning
     25 errors
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #340: Lint failed on source

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #340:
URL: https://github.com/apache/incubator-apisix-dashboard/issues/340#issuecomment-664756791






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix-dashboard] Rapiz1 commented on issue #340: Lint failed on source

Posted by GitBox <gi...@apache.org>.
Rapiz1 commented on issue #340:
URL: https://github.com/apache/incubator-apisix-dashboard/issues/340#issuecomment-664754669






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-apisix-dashboard] Rapiz1 edited a comment on issue #340: Lint failed on source

Posted by GitBox <gi...@apache.org>.
Rapiz1 edited a comment on issue #340:
URL: https://github.com/apache/incubator-apisix-dashboard/issues/340#issuecomment-664757182






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org