You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by abdelhakim deneche <ad...@gmail.com> on 2015/05/13 22:18:00 UTC

Review Request 34179: DRILL-3046 Part 1: Memory Leak after cancelling a query

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34179/
-----------------------------------------------------------

Review request for drill and Venki Korukanti.


Bugs: DRILL-3046
    https://issues.apache.org/jira/browse/DRILL-3046


Repository: drill-git


Description
-------

fixes a leak in DataTunnel where it didn't release the buffers in case it was interrupted while waiting for the sending semaphore

TestDrillbitResilience now extends DrillTest so it will time out instead of hanging indefinitely.


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataTunnel.java 143020f 
  exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java 3efb629 

Diff: https://reviews.apache.org/r/34179/diff/


Testing
-------


Thanks,

abdelhakim deneche


Re: Review Request 34179: DRILL-3046 Part 1: Memory Leak after cancelling a query

Posted by Venki Korukanti <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34179/#review83660
-----------------------------------------------------------

Ship it!


Ship It!

- Venki Korukanti


On May 13, 2015, 1:18 p.m., abdelhakim deneche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34179/
> -----------------------------------------------------------
> 
> (Updated May 13, 2015, 1:18 p.m.)
> 
> 
> Review request for drill and Venki Korukanti.
> 
> 
> Bugs: DRILL-3046
>     https://issues.apache.org/jira/browse/DRILL-3046
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> fixes a leak in DataTunnel where it didn't release the buffers in case it was interrupted while waiting for the sending semaphore
> 
> TestDrillbitResilience now extends DrillTest so it will time out instead of hanging indefinitely.
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataTunnel.java 143020f 
>   exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java 3efb629 
> 
> Diff: https://reviews.apache.org/r/34179/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> abdelhakim deneche
> 
>