You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/05/09 12:13:02 UTC
[GitHub] [kafka] tang7526 opened a new pull request, #12139: KAFKA-13821: Update Kafka Streams WordCount demo to new Processor API
tang7526 opened a new pull request, #12139:
URL: https://github.com/apache/kafka/pull/12139
https://issues.apache.org/jira/browse/KAFKA-13821
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on a diff in pull request #12139: KAFKA-13821: Update Kafka Streams WordCount demo to new Processor API
Posted by GitBox <gi...@apache.org>.
bbejeck commented on code in PR #12139:
URL: https://github.com/apache/kafka/pull/12139#discussion_r908622484
##########
streams/examples/src/main/java/org/apache/kafka/streams/examples/wordcount/WordCountTransformerDemo.java:
##########
@@ -80,17 +83,17 @@ public void init(final ProcessorContext context) {
final KeyValue<String, Integer> entry = iter.next();
System.out.println("[" + entry.key + ", " + entry.value + "]");
-
- context.forward(entry.key, entry.value.toString());
+ final Record<String, String> record = new Record<>(entry.key, entry.value.toString(), timestamp);
Review Comment:
nit: we could just inline the `new Record(...)` in the `context.forward()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck merged pull request #12139: KAFKA-13821: Update Kafka Streams WordCount demo to new Processor API
Posted by GitBox <gi...@apache.org>.
bbejeck merged PR #12139:
URL: https://github.com/apache/kafka/pull/12139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #12139: KAFKA-13821: Update Kafka Streams WordCount demo to new Processor API
Posted by GitBox <gi...@apache.org>.
bbejeck commented on PR #12139:
URL: https://github.com/apache/kafka/pull/12139#issuecomment-1169443229
Merged #12139 into trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tang7526 commented on a diff in pull request #12139: KAFKA-13821: Update Kafka Streams WordCount demo to new Processor API
Posted by GitBox <gi...@apache.org>.
tang7526 commented on code in PR #12139:
URL: https://github.com/apache/kafka/pull/12139#discussion_r908804656
##########
streams/examples/src/main/java/org/apache/kafka/streams/examples/wordcount/WordCountTransformerDemo.java:
##########
@@ -80,17 +83,17 @@ public void init(final ProcessorContext context) {
final KeyValue<String, Integer> entry = iter.next();
System.out.println("[" + entry.key + ", " + entry.value + "]");
-
- context.forward(entry.key, entry.value.toString());
+ final Record<String, String> record = new Record<>(entry.key, entry.value.toString(), timestamp);
Review Comment:
@bbejeck Done. thank you for your advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #12139: KAFKA-13821: Update Kafka Streams WordCount demo to new Processor API
Posted by GitBox <gi...@apache.org>.
bbejeck commented on PR #12139:
URL: https://github.com/apache/kafka/pull/12139#issuecomment-1169443406
Thanks, @tang7526 for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #12139: KAFKA-13821: Update Kafka Streams WordCount demo to new Processor API
Posted by GitBox <gi...@apache.org>.
bbejeck commented on PR #12139:
URL: https://github.com/apache/kafka/pull/12139#issuecomment-1168874020
Thanks for the contribution @tang7526!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tang7526 commented on pull request #12139: KAFKA-13821: Update Kafka Streams WordCount demo to new Processor API
Posted by GitBox <gi...@apache.org>.
tang7526 commented on PR #12139:
URL: https://github.com/apache/kafka/pull/12139#issuecomment-1165646326
@chia7712 Could you help to review this PR? thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tang7526 commented on a diff in pull request #12139: KAFKA-13821: Update Kafka Streams WordCount demo to new Processor API
Posted by GitBox <gi...@apache.org>.
tang7526 commented on code in PR #12139:
URL: https://github.com/apache/kafka/pull/12139#discussion_r908804656
##########
streams/examples/src/main/java/org/apache/kafka/streams/examples/wordcount/WordCountTransformerDemo.java:
##########
@@ -80,17 +83,17 @@ public void init(final ProcessorContext context) {
final KeyValue<String, Integer> entry = iter.next();
System.out.println("[" + entry.key + ", " + entry.value + "]");
-
- context.forward(entry.key, entry.value.toString());
+ final Record<String, String> record = new Record<>(entry.key, entry.value.toString(), timestamp);
Review Comment:
@bbejeck Thank you for your advice. I've already done it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #12139: KAFKA-13821: Update Kafka Streams WordCount demo to new Processor API
Posted by GitBox <gi...@apache.org>.
bbejeck commented on PR #12139:
URL: https://github.com/apache/kafka/pull/12139#issuecomment-1168875551
@vvcephei | @jeqo for a second pair of eyes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org