[jira] [Commented] (APEXMALHAR-2100) Development of Inner Join Operator using Spillable Datastructures

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/APEXMALHAR-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403845#comment-15403845 ] 

ASF GitHub Bot commented on APEXMALHAR-2100:
--------------------------------------------

Github user chaithu14 commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/330#discussion_r73141485
  
    --- Diff: library/src/main/java/com/datatorrent/lib/join/AbstractInnerJoinOperator.java ---
    @@ -0,0 +1,331 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package com.datatorrent.lib.join;
    +
    +import java.util.Arrays;
    +import java.util.List;
    +
    +import javax.validation.constraints.NotNull;
    +
    +import org.apache.apex.malhar.lib.state.spillable.Spillable;
    +import org.apache.apex.malhar.lib.state.spillable.SpillableComplexComponent;
    +import org.apache.apex.malhar.lib.state.spillable.inmem.InMemSpillableComplexComponent;
    +import com.google.common.base.Preconditions;
    +
    +import com.datatorrent.api.AutoMetric;
    +import com.datatorrent.api.Context;
    +import com.datatorrent.common.util.BaseOperator;
    +
    +/**
    + * <p>
    + * An abstract implementation of inner join operator. Operator receives tuples from two streams,
    + * applies the join operation based on constraint and emit the joined value.
    + * Concrete classes should provide implementation to extractKey, extractTime, mergeTuples methods.
    + *
    + * <b>Properties:</b><br>
    + * <b>includeFieldStr</b>: List of comma separated fields to be added to the output tuple.
    + *                         Ex: Field1,Field2;Field3,Field4<br>
    + * <b>keyFields</b>: List of comma separated key field for both the streams. Ex: Field1,Field2<br>
    --- End diff --
    
    Yes. If there are multiple key fields from each stream then the primary key field has to specify in keyFields and the other key fields has to take care in mergeTuples().


> Development of Inner Join Operator using Spillable Datastructures
> -----------------------------------------------------------------
>
>                 Key: APEXMALHAR-2100
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2100
>             Project: Apache Apex Malhar
>          Issue Type: Task
>            Reporter: Chaitanya
>            Assignee: Chaitanya
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)