You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2018/07/12 22:44:58 UTC
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10933
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule()
......................................................................
IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Currently codegen crashed during FinalizeModule() where it tries to
clean up half-baked handcrafted functions. This happens only for the
cases where the code generating the handcrafted IR calls
eraseFromParent() on failure which also deletes the memory held by the
function pointer and therefore causes a crash during clean up in
FinalizeModule().
Testing:
Tested manually to verify the code path that initially caused the
crash was being excercised.
Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0
---
M be/src/exec/hash-table.cc
M be/src/exec/hdfs-avro-scanner.cc
M be/src/exec/hdfs-scanner.cc
3 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/10933/1
--
To view, visit http://gerrit.cloudera.org:8080/10933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0
Gerrit-Change-Number: 10933
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule()
......................................................................
Patch Set 1:
> > Change LGTM. May be it helps to add some end-to-end test which
> > exercises the hashT table paths with CHAR type to confirm it's
> > fixed. Same can be said about the scanner changes.
> >
> > In the long run, every codegen changes which include handcrafted
> IR
> > should include CHAR type as part of the tests.
>
> CHAR type was a part of the manual testing that i did for
> IMPALA-6177. The thing that I am concerned about is that if we
> decide to add tests for CHAR for only the changes in this patch,
> then to get full coverage we would also have to add test cases that
> exercise all handcrafted IR generation code paths that have failure
> modes for CHAR
There may be ways to automate it but I agree that's a lot of cases to cover. We may not need to take on all of them in this patch. My suspicion is that we already added some test cases when codegen logic was introduced in exec nodes so they may need to be extended only to cover CHAR. That said, it is a bit tedious and ideally we want some form of query generator to generate these queries.
--
To view, visit http://gerrit.cloudera.org:8080/10933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0
Gerrit-Change-Number: 10933
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jul 2018 23:04:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule()
......................................................................
Patch Set 1:
> Change LGTM. May be it helps to add some end-to-end test which
> exercises the hashT table paths with CHAR type to confirm it's
> fixed. Same can be said about the scanner changes.
>
> In the long run, every codegen changes which include handcrafted IR
> should include CHAR type as part of the tests.
CHAR type was a part of the manual testing that i did for IMPALA-6177. The thing that I am concerned about is that if we decide to add tests for CHAR for only the changes in this patch, then to get full coverage we would also have to add test cases that exercise all handcrafted IR generation code paths that have failure modes for CHAR
--
To view, visit http://gerrit.cloudera.org:8080/10933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0
Gerrit-Change-Number: 10933
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jul 2018 22:58:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule()
......................................................................
Patch Set 2:
added 2 regression tests for the methods in hash-table.cc
--
To view, visit http://gerrit.cloudera.org:8080/10933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0
Gerrit-Change-Number: 10933
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 00:29:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10933 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule()
......................................................................
IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Currently codegen crashed during FinalizeModule() where it tries to
clean up half-baked handcrafted functions. This happens only for the
cases where the code generating the handcrafted IR calls
eraseFromParent() on failure which also deletes the memory held by the
function pointer and therefore causes a crash during clean up in
FinalizeModule().
Testing:
Added regression tests that verify that failure code paths in
the previously offending methods don't crash Impala.
Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0
Reviewed-on: http://gerrit.cloudera.org:8080/10933
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/hash-table.cc
M be/src/exec/hdfs-avro-scanner.cc
M be/src/exec/hdfs-scanner.cc
M tests/query_test/test_codegen.py
4 files changed, 17 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0
Gerrit-Change-Number: 10933
Gerrit-PatchSet: 4
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Posted by "Zoram Thanga (Code Review)" <ge...@cloudera.org>.
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule()
......................................................................
Patch Set 1:
> I am not sure what kind of tests I can add to this, since this
> looks more like an abuse of API than an actual functionality that i
> can test. any ideas welcomed
How about the test case that repro'd this? I mean the one Balasz posted?
--
To view, visit http://gerrit.cloudera.org:8080/10933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0
Gerrit-Change-Number: 10933
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jul 2018 22:50:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule()
......................................................................
Patch Set 1:
Change LGTM. May be it helps to add some end-to-end test which exercises the hashT table paths with CHAR type to confirm it's fixed. Same can be said about the scanner changes.
In the long run, every codegen changes which include handcrafted IR should include CHAR type as part of the tests.
--
To view, visit http://gerrit.cloudera.org:8080/10933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0
Gerrit-Change-Number: 10933
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jul 2018 22:52:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule()
......................................................................
Patch Set 1:
Another idea is to inject fault at expression codegen functions to randomly fail codegen. This may not cover cases like scanners but should still provide reasonable coverage for other exec nodes.
--
To view, visit http://gerrit.cloudera.org:8080/10933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0
Gerrit-Change-Number: 10933
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jul 2018 23:06:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Zoram Thanga, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10933
to look at the new patch set (#2).
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule()
......................................................................
IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Currently codegen crashed during FinalizeModule() where it tries to
clean up half-baked handcrafted functions. This happens only for the
cases where the code generating the handcrafted IR calls
eraseFromParent() on failure which also deletes the memory held by the
function pointer and therefore causes a crash during clean up in
FinalizeModule().
Testing:
Added regression tests that verify that failure code paths in
the previously offending methods don't crash Impala.
Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0
---
M be/src/exec/hash-table.cc
M be/src/exec/hdfs-avro-scanner.cc
M be/src/exec/hdfs-scanner.cc
M tests/query_test/test_codegen.py
4 files changed, 17 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/10933/2
--
To view, visit http://gerrit.cloudera.org:8080/10933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0
Gerrit-Change-Number: 10933
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule()
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0
Gerrit-Change-Number: 10933
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 00:49:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule()
......................................................................
Patch Set 1:
I am not sure what kind of tests I can add to this, since this looks more like an abuse of API than an actual functionality that i can test. any ideas welcomed
--
To view, visit http://gerrit.cloudera.org:8080/10933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0
Gerrit-Change-Number: 10933
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jul 2018 22:46:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule()
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2809/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/10933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0
Gerrit-Change-Number: 10933
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 00:49:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule()
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/10933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0
Gerrit-Change-Number: 10933
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 00:35:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule()
......................................................................
Patch Set 1:
> > I am not sure what kind of tests I can add to this, since this
> > looks more like an abuse of API than an actual functionality that
> i
> > can test. any ideas welcomed
>
> How about the test case that repro'd this? I mean the one Balasz
> posted?
I can, but i am wondering if its worth adding a test case that tests a very specific bug. Like if someone where to add similar code to there nodes/code paths, the added test wont be able to catch that.
--
To view, visit http://gerrit.cloudera.org:8080/10933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0
Gerrit-Change-Number: 10933
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jul 2018 22:54:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule()
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0
Gerrit-Change-Number: 10933
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 04:07:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0
Gerrit-Change-Number: 10933
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 00:43:49 +0000
Gerrit-HasComments: No