You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/09/20 13:03:00 UTC
[jira] [Commented] (ARROW-1578) [C++/Python] Run lint checks in
Travis CI to fail for linting issues as early as possible
[ https://issues.apache.org/jira/browse/ARROW-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173135#comment-16173135 ]
ASF GitHub Bot commented on ARROW-1578:
---------------------------------------
GitHub user wesm opened a pull request:
https://github.com/apache/arrow/pull/1118
ARROW-1578: [C++] Run lint checks in Travis CI much earlier at before_script stage to fail faster
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wesm/arrow ARROW-1578
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/arrow/pull/1118.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1118
----
commit 329f01790ad5a16965e744acf54440d7fb010c5e
Author: Wes McKinney <we...@twosigma.com>
Date: 2017-09-20T12:58:34Z
Run lint checks before compiling anything. Make cpplint warning
Change-Id: Ib812f49e248540c7283a1e058f26925dbc36af00
commit 28fc3fb07589551959664db31997a9a0d8599b0c
Author: Wes McKinney <we...@twosigma.com>
Date: 2017-09-20T13:02:00Z
Typo
Change-Id: Ifeae6a35fc35939bfdaf191b2639b3aee9f27274
----
> [C++/Python] Run lint checks in Travis CI to fail for linting issues as early as possible
> -----------------------------------------------------------------------------------------
>
> Key: ARROW-1578
> URL: https://issues.apache.org/jira/browse/ARROW-1578
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++, Python
> Reporter: Wes McKinney
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> The lint checks are run relatively late in the CI process, and a build may fail after holding a worker for ~20 minutes or more. These could fail much sooner and free up build slaves
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)