[GitHub] [ignite] agura commented on a change in pull request #7446: IGNITE-12464 : Service metrics

[GitBox <gi...@apache.org>]

agura commented on a change in pull request #7446: IGNITE-12464 : Service metrics
URL: https://github.com/apache/ignite/pull/7446#discussion_r381247504
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/service/IgniteServiceProcessor.java
 ##########
 @@ -188,6 +205,80 @@
     /** Disconnected flag. */
     private volatile boolean disconnected;
 
+    /**
+     * Creates proper registry name for service metrics.
+     *
+     * @param srvcName Name of the service.
+     * @return Registry name.
+     */
+    static String serviceMetricsName(String srvcName) {
+        return metricName(METRIC_REGISTRY_INVOCATIONS, srvcName);
+    }
+
+    /**
+     * @param method       Method for the invocation timings.
+     * @param pkgNameDepth Level of package name abbreviation. @see #abbreviatePgkName(Class, int).
+     * @return Metric name for {@code method}. Doesn't guaratee same name with same {@code pkgNameDepth} is used for
+     * real metric registry.
+     */
+    static String methodMetricName(Method method, int pkgNameDepth) {
 
 Review comment:
   What if we have set of overloaded methods?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services