[GitHub] [ignite] isapego commented on a diff in pull request #10157: IGNITE-15759 Remove LOCAL caches

[GitBox <gi...@apache.org>]

isapego commented on code in PR #10157:
URL: https://github.com/apache/ignite/pull/10157#discussion_r941197346


##########
modules/platforms/dotnet/Apache.Ignite.Core.Tests/Cache/Store/CacheStoreTestCodeConfig.cs:
##########
@@ -1,107 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-namespace Apache.Ignite.Core.Tests.Cache.Store
-{
-    using System;
-    using Apache.Ignite.Core.Binary;
-    using Apache.Ignite.Core.Cache.Configuration;
-    using Apache.Ignite.Core.Cache.Store;
-    using Apache.Ignite.Core.Common;
-    using NUnit.Framework;
-
-    /// <summary>
-    /// Tests cache store without Spring.
-    /// </summary>
-    [TestFixture]
-    public class CacheStoreTestCodeConfig : CacheStoreTest

Review Comment:
   Why would you remove these tests alltogether? This is nothing that can not be implemented on `partitioned` caches, is it?



##########
modules/platforms/dotnet/Apache.Ignite.Core/Cache/Configuration/CacheRebalanceMode.cs:
##########
@@ -25,8 +25,7 @@ namespace Apache.Ignite.Core.Cache.Configuration
     /// while partitioned caches will only load the entries for which current node is primary or backup.
     /// <para />
     /// Note that rebalance mode only makes sense for <see cref="CacheMode.Replicated"/> 
-    /// and <see cref="CacheMode.Partitioned"/> caches. Caches with <see cref="CacheMode.Local"/> 
-    /// mode are local by definition and therefore cannot rebalance any values from neighboring nodes.
+    /// and <see cref="CacheMode.Partitioned"/> caches.

Review Comment:
   This note does not have a lot of sense right now. Let's change it to something like:
   ```
   Rebalance mode affects both <see cref="CacheMode.Replicated"/>
   and <see cref="CacheMode.Partitioned"/> caches
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org