You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/09/23 13:30:08 UTC

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2848: ARTEMIS-2497: [AMQP] Allow handling of the reject disposition to be configured

clebertsuconic commented on a change in pull request #2848: ARTEMIS-2497: [AMQP] Allow handling of the reject disposition to be configured
URL: https://github.com/apache/activemq-artemis/pull/2848#discussion_r327114316
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java
 ##########
 @@ -306,6 +306,8 @@
 
    private Long globalMaxSize;
 
+   private boolean amqpTreatRejectAsUnmodifiedDeliveryFailed = ActiveMQDefaultConfiguration.getDefaultTreatRejectAsUnmodifiedDeliveryFailed();
 
 Review comment:
   I would use the ProtocolManager configuration, being a property of the acceptor, instead of a global property for such thing.
   
   That way you can configure this as part of the acceptor properties.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services