Re: [PR] fix(translations): Fix translation of time-related strings like "7 seconds ago", "a minute ago", etc [superset]

["PolinaFam (via GitHub)" <gi...@apache.org>]

PolinaFam commented on code in PR #34051:
URL: https://github.com/apache/superset/pull/34051#discussion_r2266413945


##########
superset/models/helpers.py:
##########
@@ -103,6 +103,7 @@
 VIRTUAL_TABLE_ALIAS = "virtual_table"
 SERIES_LIMIT_SUBQ_ALIAS = "series_limit"
 ADVANCED_DATA_TYPES = config["ADVANCED_DATA_TYPES"]
+DEFAULT_LOCALE = "en"

Review Comment:
   Actually there is no need to use `BABEL_DEFAULT_LOCALE` or `DEFAULT_LOCALE` as `get_locale()` will return default locale if it wasn't changed. Updated PR according to this discussion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org