You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Jörg Maier (Created JIRA)" <ji...@apache.org> on 2012/02/20 07:45:38 UTC
[jira] [Created] (SOLR-3144) Parameter marshalling is broken in
Solrj JavaBinUpdateRequestCodec
Parameter marshalling is broken in Solrj JavaBinUpdateRequestCodec
-------------------------------------------------------------------
Key: SOLR-3144
URL: https://issues.apache.org/jira/browse/SOLR-3144
Project: Solr
Issue Type: Bug
Components: clients - java
Affects Versions: 4.0
Reporter: Jörg Maier
Fix For: 4.0
The parameter marshalling de-marshalling is broken in Solrj's JavaBinUpdateRequestCodec.
The bug can be reproduced by adding a parameter e.g. overwrite=false as parameter to the UpdateRequest. After desiarilizing on the backend side the value will be not "false" it will be "[false]" which results in an Exception in the backend and documents will not be imported.
This issue can easily be fixed by replacing the serialization method with the correct one in SolrParams. See also this gist for a working version: https://gist.github.com/1853544
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3144) Parameter marshalling is broken in
Solrj JavaBinUpdateRequestCodec
Posted by "Jörg Maier (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jörg Maier updated SOLR-3144:
-----------------------------
Attachment: JavaBinUpdateRequestCodec.patch
Attached patch.
> Parameter marshalling is broken in Solrj JavaBinUpdateRequestCodec
> -------------------------------------------------------------------
>
> Key: SOLR-3144
> URL: https://issues.apache.org/jira/browse/SOLR-3144
> Project: Solr
> Issue Type: Bug
> Components: clients - java
> Affects Versions: 4.0
> Reporter: Jörg Maier
> Fix For: 4.0
>
> Attachments: JavaBinUpdateRequestCodec.patch
>
>
> The parameter marshalling de-marshalling is broken in Solrj's JavaBinUpdateRequestCodec.
> The bug can be reproduced by adding a parameter e.g. overwrite=false as parameter to the UpdateRequest. After desiarilizing on the backend side the value will be not "false" it will be "[false]" which results in an Exception in the backend and documents will not be imported.
> This issue can easily be fixed by replacing the serialization method with the correct one in SolrParams. See also this gist for a working version: https://gist.github.com/1853544
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3144) Parameter marshalling is broken in
Solrj JavaBinUpdateRequestCodec
Posted by "Jörg Maier (Resolved JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jörg Maier resolved SOLR-3144.
------------------------------
Resolution: Duplicate
Hi Sami,
i was working on an earlier build than the current head. Obviously previous to your fix. I couldnt verify the existence of this bug on trunk anymore and everything works fine for me. I missed SOLR-3037.
However it might be a good idea to replace the toNamedList method in the Codec by the toNamedList method from SolrParams.
I close this as duplicate to SOLR-3037.
> Parameter marshalling is broken in Solrj JavaBinUpdateRequestCodec
> -------------------------------------------------------------------
>
> Key: SOLR-3144
> URL: https://issues.apache.org/jira/browse/SOLR-3144
> Project: Solr
> Issue Type: Bug
> Components: clients - java
> Affects Versions: 4.0
> Reporter: Jörg Maier
> Fix For: 4.0
>
> Attachments: JavaBinUpdateRequestCodec.patch
>
>
> The parameter marshalling de-marshalling is broken in Solrj's JavaBinUpdateRequestCodec.
> The bug can be reproduced by adding a parameter e.g. overwrite=false as parameter to the UpdateRequest. After desiarilizing on the backend side the value will be not "false" it will be "[false]" which results in an Exception in the backend and documents will not be imported.
> This issue can easily be fixed by replacing the serialization method with the correct one in SolrParams. See also this gist for a working version: https://gist.github.com/1853544
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3144) Parameter marshalling is broken in
Solrj JavaBinUpdateRequestCodec
Posted by "Sami Siren (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214440#comment-13214440 ]
Sami Siren commented on SOLR-3144:
----------------------------------
I committed the changes you proposed in r1292690. Thanks!
> Parameter marshalling is broken in Solrj JavaBinUpdateRequestCodec
> -------------------------------------------------------------------
>
> Key: SOLR-3144
> URL: https://issues.apache.org/jira/browse/SOLR-3144
> Project: Solr
> Issue Type: Bug
> Components: clients - java
> Affects Versions: 4.0
> Reporter: Jörg Maier
> Fix For: 4.0
>
> Attachments: JavaBinUpdateRequestCodec.patch
>
>
> The parameter marshalling de-marshalling is broken in Solrj's JavaBinUpdateRequestCodec.
> The bug can be reproduced by adding a parameter e.g. overwrite=false as parameter to the UpdateRequest. After desiarilizing on the backend side the value will be not "false" it will be "[false]" which results in an Exception in the backend and documents will not be imported.
> This issue can easily be fixed by replacing the serialization method with the correct one in SolrParams. See also this gist for a working version: https://gist.github.com/1853544
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3144) Parameter marshalling is broken in
Solrj JavaBinUpdateRequestCodec
Posted by "Sami Siren (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214401#comment-13214401 ]
Sami Siren commented on SOLR-3144:
----------------------------------
b1. However it might be a good idea to replace the toNamedList method in the Codec by the toNamedList method from SolrParams.
Yeah, I agree.
> Parameter marshalling is broken in Solrj JavaBinUpdateRequestCodec
> -------------------------------------------------------------------
>
> Key: SOLR-3144
> URL: https://issues.apache.org/jira/browse/SOLR-3144
> Project: Solr
> Issue Type: Bug
> Components: clients - java
> Affects Versions: 4.0
> Reporter: Jörg Maier
> Fix For: 4.0
>
> Attachments: JavaBinUpdateRequestCodec.patch
>
>
> The parameter marshalling de-marshalling is broken in Solrj's JavaBinUpdateRequestCodec.
> The bug can be reproduced by adding a parameter e.g. overwrite=false as parameter to the UpdateRequest. After desiarilizing on the backend side the value will be not "false" it will be "[false]" which results in an Exception in the backend and documents will not be imported.
> This issue can easily be fixed by replacing the serialization method with the correct one in SolrParams. See also this gist for a working version: https://gist.github.com/1853544
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3144) Parameter marshalling is broken in
Solrj JavaBinUpdateRequestCodec
Posted by "Sami Siren (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213758#comment-13213758 ]
Sami Siren commented on SOLR-3144:
----------------------------------
Hi Jörg,
What version did you see this problem with? I tried to fix this already in SOLR-3037 but perhaps I missed something...
> Parameter marshalling is broken in Solrj JavaBinUpdateRequestCodec
> -------------------------------------------------------------------
>
> Key: SOLR-3144
> URL: https://issues.apache.org/jira/browse/SOLR-3144
> Project: Solr
> Issue Type: Bug
> Components: clients - java
> Affects Versions: 4.0
> Reporter: Jörg Maier
> Fix For: 4.0
>
> Attachments: JavaBinUpdateRequestCodec.patch
>
>
> The parameter marshalling de-marshalling is broken in Solrj's JavaBinUpdateRequestCodec.
> The bug can be reproduced by adding a parameter e.g. overwrite=false as parameter to the UpdateRequest. After desiarilizing on the backend side the value will be not "false" it will be "[false]" which results in an Exception in the backend and documents will not be imported.
> This issue can easily be fixed by replacing the serialization method with the correct one in SolrParams. See also this gist for a working version: https://gist.github.com/1853544
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Closed] (SOLR-3144) Parameter marshalling is broken in
Solrj JavaBinUpdateRequestCodec
Posted by "Jörg Maier (Closed JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jörg Maier closed SOLR-3144.
----------------------------
> Parameter marshalling is broken in Solrj JavaBinUpdateRequestCodec
> -------------------------------------------------------------------
>
> Key: SOLR-3144
> URL: https://issues.apache.org/jira/browse/SOLR-3144
> Project: Solr
> Issue Type: Bug
> Components: clients - java
> Affects Versions: 4.0
> Reporter: Jörg Maier
> Fix For: 4.0
>
> Attachments: JavaBinUpdateRequestCodec.patch
>
>
> The parameter marshalling de-marshalling is broken in Solrj's JavaBinUpdateRequestCodec.
> The bug can be reproduced by adding a parameter e.g. overwrite=false as parameter to the UpdateRequest. After desiarilizing on the backend side the value will be not "false" it will be "[false]" which results in an Exception in the backend and documents will not be imported.
> This issue can easily be fixed by replacing the serialization method with the correct one in SolrParams. See also this gist for a working version: https://gist.github.com/1853544
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org