[GitHub] [superset] vnourdin commented on a change in pull request #13116: feat(helm): Helm template for Celery beat (for reporting and alerting)

[GitBox <gi...@apache.org>]

vnourdin commented on a change in pull request #13116:
URL: https://github.com/apache/superset/pull/13116#discussion_r576004351



##########
File path: helm/superset/templates/deployment-beat.yaml
##########
@@ -0,0 +1,95 @@
+{{- if .Values.supersetBeat.enabled -}}
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: {{ template "superset.fullname" . }}-beat

Review comment:
       I initially named the pods the same way you did, but some colleague said that `beat` is kind of generic, and it would be better naming it `{{ template "superset.fullname" . }}-celerybeat`.
   I let you judge :wink: 

##########
File path: helm/superset/values.yaml
##########
@@ -165,6 +165,25 @@ supersetWorker:
             name: '{{ tpl .Values.envFromSecret . }}'
       command: [ "/bin/sh", "-c", "until nc -zv $DB_HOST $DB_PORT -w1; do echo 'waiting for db'; sleep 1; done" ]
 
+##
+## Superset beat configuration (to trigger scheduled jobs like reports)
+supersetBeat:
+  # this is only required if you intend to use reports and alerts (?)

Review comment:
       For the moment, yes
   ```suggestion
     # This is only required if you intend to use alerts and reports
   ```

##########
File path: helm/superset/templates/deployment-worker.yaml
##########
@@ -31,11 +31,16 @@ spec:
       release: {{ .Release.Name }}
   template:
     metadata:
-      {{ if .Values.supersetWorker.forceReload }}
       annotations:
+        checksum/superset_config.py: {{ include "superset-config" . | sha256sum }}
+        checksum/connections: {{ .Values.supersetNode.connections | toYaml | sha256sum }}
+        checksum/extraConfigs: {{ .Values.extraConfigs | toYaml | sha256sum }}
+        checksum/extraSecretEnv: {{ .Values.extraSecretEnv | toYaml | sha256sum }}
+        checksum/configOverrides: {{ .Values.configOverrides | toYaml | sha256sum }}

Review comment:
       _[K8S newbie]_ What's the point of those annotations? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org