[jira] [Commented] (CALCITE-2736) ReduceExpressionsRule never reduces dynamic expressions but this should be configurable

["Stamatis Zampetakis (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613594#comment-17613594 ] 

Stamatis Zampetakis commented on CALCITE-2736:
----------------------------------------------

As part of this change the following method was modified (a new parameter was added) and during upgrade to 1.28.0 there were compilation errors cause there were callers to this method. This is a breaking change and should be part of the release notes. 
{code:java}
  protected static boolean reduceExpressions(RelNode rel, List<RexNode> expList,
      RelOptPredicateList predicates, boolean unknownAsFalse,
      boolean matchNullability)
{code}
Reminder: usually we follow the telescopic pattern; first deprecate the old method and add new method with new parameter.


> ReduceExpressionsRule never reduces dynamic expressions but this should be configurable
> ---------------------------------------------------------------------------------------
>
>                 Key: CALCITE-2736
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2736
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Jacques Nadeau
>            Assignee: Jacques Nadeau
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.28.0
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> There are situations where it is helpful to reduce dynamic SqlCalls. Right now, the ReduceExpressionsRule always avoids doing this. We should enhance the rule so this can be configurable depending on where in planning the rule is used.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)