You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2014/11/12 02:15:24 UTC
Review Request 27897: Create DAO and Unit Tests for HostVersion
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27897/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Yurii Shylov.
Bugs: AMBARI-8271
https://issues.apache.org/jira/browse/AMBARI-8271
Repository: ambari
Description
-------
Create DAO and Unit Tests for HostVersionEntity that is needed for Rolling Upgrades - Bootstrap
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 69a2a9d
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java 46476da
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostEntity.java 8f850e0
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 6bad11b
ambari-server/src/main/java/org/apache/ambari/server/state/HostVersionState.java b0a0ee2
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/27897/diff/
Testing
-------
Ran unit tests
Thanks,
Alejandro Fernandez
Re: Review Request 27897: Create DAO and Unit Tests for HostVersion
Posted by Yurii Shylov <yu...@gmail.com>.
> On Ноя. 12, 2014, 11:19 д.п., Yurii Shylov wrote:
> > Ship It!
Swapped javadocs is a very tiny issue, it's not worth updating the patch here, it can be done in any of further patches
- Yurii
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27897/#review60975
-----------------------------------------------------------
On Ноя. 12, 2014, 1:15 д.п., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27897/
> -----------------------------------------------------------
>
> (Updated Ноя. 12, 2014, 1:15 д.п.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Yurii Shylov.
>
>
> Bugs: AMBARI-8271
> https://issues.apache.org/jira/browse/AMBARI-8271
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create DAO and Unit Tests for HostVersionEntity that is needed for Rolling Upgrades - Bootstrap
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 69a2a9d
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java 46476da
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostEntity.java 8f850e0
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 6bad11b
> ambari-server/src/main/java/org/apache/ambari/server/state/HostVersionState.java b0a0ee2
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27897/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 27897: Create DAO and Unit Tests for HostVersion
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27897/#review60975
-----------------------------------------------------------
Ship it!
Ship It!
- Yurii Shylov
On Ноя. 12, 2014, 1:15 д.п., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27897/
> -----------------------------------------------------------
>
> (Updated Ноя. 12, 2014, 1:15 д.п.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Yurii Shylov.
>
>
> Bugs: AMBARI-8271
> https://issues.apache.org/jira/browse/AMBARI-8271
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create DAO and Unit Tests for HostVersionEntity that is needed for Rolling Upgrades - Bootstrap
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 69a2a9d
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java 46476da
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostEntity.java 8f850e0
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 6bad11b
> ambari-server/src/main/java/org/apache/ambari/server/state/HostVersionState.java b0a0ee2
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27897/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 27897: Create DAO and Unit Tests for HostVersion
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27897/#review60974
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
<https://reviews.apache.org/r/27897/#comment102419>
Should be "Retrieve all of the host versions for the given cluster name and host name."
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
<https://reviews.apache.org/r/27897/#comment102420>
Should be "Retrieve all of the host versions for the given cluster name, host name, and state."
- Yurii Shylov
On Ноя. 12, 2014, 1:15 д.п., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27897/
> -----------------------------------------------------------
>
> (Updated Ноя. 12, 2014, 1:15 д.п.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Yurii Shylov.
>
>
> Bugs: AMBARI-8271
> https://issues.apache.org/jira/browse/AMBARI-8271
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create DAO and Unit Tests for HostVersionEntity that is needed for Rolling Upgrades - Bootstrap
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 69a2a9d
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java 46476da
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostEntity.java 8f850e0
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 6bad11b
> ambari-server/src/main/java/org/apache/ambari/server/state/HostVersionState.java b0a0ee2
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27897/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 27897: Create DAO and Unit Tests for HostVersion
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27897/#review60973
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 12, 2014, 1:15 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27897/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 1:15 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Yurii Shylov.
>
>
> Bugs: AMBARI-8271
> https://issues.apache.org/jira/browse/AMBARI-8271
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create DAO and Unit Tests for HostVersionEntity that is needed for Rolling Upgrades - Bootstrap
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 69a2a9d
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java 46476da
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostEntity.java 8f850e0
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 6bad11b
> ambari-server/src/main/java/org/apache/ambari/server/state/HostVersionState.java b0a0ee2
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27897/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 27897: Create DAO and Unit Tests for HostVersion
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27897/#review61029
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Nov. 11, 2014, 8:15 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27897/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2014, 8:15 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Yurii Shylov.
>
>
> Bugs: AMBARI-8271
> https://issues.apache.org/jira/browse/AMBARI-8271
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create DAO and Unit Tests for HostVersionEntity that is needed for Rolling Upgrades - Bootstrap
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java 69a2a9d
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java 46476da
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostEntity.java 8f850e0
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 6bad11b
> ambari-server/src/main/java/org/apache/ambari/server/state/HostVersionState.java b0a0ee2
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27897/diff/
>
>
> Testing
> -------
>
> Ran unit tests
>
>
> Thanks,
>
> Alejandro Fernandez
>
>