[GitHub] [kafka] machi1990 commented on a diff in pull request #13909: KAFKA-14957: Update-Description-String

["machi1990 (via GitHub)" <gi...@apache.org>]

machi1990 commented on code in PR #13909:
URL: https://github.com/apache/kafka/pull/13909#discussion_r1239870549


##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -718,7 +718,7 @@ public class StreamsConfig extends AbstractConfig {
     /** {@code state.dir} */
     @SuppressWarnings("WeakerAccess")
     public static final String STATE_DIR_CONFIG = "state.dir";
-    private static final String STATE_DIR_DOC = "Directory location for state store. This path must be unique for each streams instance sharing the same underlying filesystem.";
+    private static final String STATE_DIR_DOC = "Directory location for state store. This path must be unique for each streams instance sharing the same underlying filesystem. Note that the location will be different in each environment as it is computed using System.getProperty(\"java.io.tmpdir\")";

Review Comment:
   ```suggestion
       private static final String STATE_DIR_DOC = "Directory location for state store. This path must be unique for each streams instance sharing the same underlying filesystem. Note that if not configured, then the default location will be different in each environment as it is computed using System.getProperty(\"java.io.tmpdir\")";
   ```
   I think we should mention that only the default value depends on the output of `System.getProperty("java.io.tmpdir")`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org