[GitHub] [pinot] klsince commented on a change in pull request #7967: Make SegmentDirectoryLoader package urls configurable

[GitBox <gi...@apache.org>]

klsince commented on a change in pull request #7967:
URL: https://github.com/apache/pinot/pull/7967#discussion_r776601602



##########
File path: pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/loader/SegmentDirectoryLoaderRegistry.java
##########
@@ -37,14 +41,28 @@
  */
 public class SegmentDirectoryLoaderRegistry {
   private static final Logger LOGGER = LoggerFactory.getLogger(SegmentDirectoryLoaderRegistry.class);
-
   public static final String DEFAULT_SEGMENT_DIRECTORY_LOADER_NAME = "default";
-  private static final Map<String, SegmentDirectoryLoader> SEGMENT_DIRECTORY_LOADER_MAP = new HashMap<>();
+  private static final Map<String, SegmentDirectoryLoader> SEGMENT_DIRECTORY_LOADER_MAP = new ConcurrentHashMap<>();

Review comment:
       this change of using concurrent hash map may be kept




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org