You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Antoine Levy-Lambert (JIRA)" <de...@velocity.apache.org> on 2007/02/24 09:13:06 UTC
[jira] Created: (VELOCITY-521) please do not force to use JDK 1.4
for running the package target in build.xml
please do not force to use JDK 1.4 for running the package target in build.xml
------------------------------------------------------------------------------
Key: VELOCITY-521
URL: https://issues.apache.org/jira/browse/VELOCITY-521
Project: Velocity
Issue Type: Bug
Components: Build
Affects Versions: 1.6
Environment: all
Reporter: Antoine Levy-Lambert
Priority: Minor
build.xml target package forces to use exactly JDK 1.4.
Would it not be better to build with target=1.4, source=1.4 and to simply check that the JDK version is >= 1.4
I will attach a patch to this effect.
Regards,
Antoine
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-521) please do not force to use JDK 1.4
for running the package target in build.xml
Posted by "Henning Schmiedehausen (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478373 ]
Henning Schmiedehausen commented on VELOCITY-521:
-------------------------------------------------
Enforcing the version of the compiler might be good to catch errors on the release manager side, however it makes a PITA for anyone that wants to build the release for internal purposes. There are good reasons (we actually recommend it in the README IIRC) to rebuild with 1.3 if you are stuck in a legacy environment.
I'd suggest to back that patch out from build.xml and add an internal, non-commented (so that it does not show up in "ant -p") target, e.g. dist-package, that is used by the release manager to build the distribution.
I also would like to see this clearly documented in the velocity docs.
That is the kind of "last minute rush" patches, that I did want to avoid. That patch should IMHO not have been in the 1.5 release, that would have been good for 1.5.1 or 1.6
> please do not force to use JDK 1.4 for running the package target in build.xml
> ------------------------------------------------------------------------------
>
> Key: VELOCITY-521
> URL: https://issues.apache.org/jira/browse/VELOCITY-521
> Project: Velocity
> Issue Type: Bug
> Components: Build
> Affects Versions: 1.6
> Environment: all
> Reporter: Antoine Levy-Lambert
> Assigned To: Will Glass-Husain
> Priority: Minor
> Fix For: 1.6
>
> Attachments: patch.txt
>
>
> build.xml target package forces to use exactly JDK 1.4.
> Would it not be better to build with target=1.4, source=1.4 and to simply check that the JDK version is >= 1.4
> I will attach a patch to this effect.
> Regards,
> Antoine
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Resolved: (VELOCITY-521) please do not force to use JDK 1.4
for running the package target in build.xml
Posted by "Will Glass-Husain (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Will Glass-Husain resolved VELOCITY-521.
----------------------------------------
Resolution: Fixed
Henning changed the build file a while ago. I added a note to the wiki, and also set the target and source javac options to 1.4 as Antoine suggested.
> please do not force to use JDK 1.4 for running the package target in build.xml
> ------------------------------------------------------------------------------
>
> Key: VELOCITY-521
> URL: https://issues.apache.org/jira/browse/VELOCITY-521
> Project: Velocity
> Issue Type: Bug
> Components: Build
> Affects Versions: 1.6
> Environment: all
> Reporter: Antoine Levy-Lambert
> Assignee: Will Glass-Husain
> Priority: Minor
> Fix For: 1.6
>
> Attachments: patch.txt
>
>
> build.xml target package forces to use exactly JDK 1.4.
> Would it not be better to build with target=1.4, source=1.4 and to simply check that the JDK version is >= 1.4
> I will attach a patch to this effect.
> Regards,
> Antoine
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (VELOCITY-521) please do not force to use JDK 1.4
for running the package target in build.xml
Posted by "Will Glass-Husain (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Will Glass-Husain updated VELOCITY-521:
---------------------------------------
Fix Version/s: 1.6
> please do not force to use JDK 1.4 for running the package target in build.xml
> ------------------------------------------------------------------------------
>
> Key: VELOCITY-521
> URL: https://issues.apache.org/jira/browse/VELOCITY-521
> Project: Velocity
> Issue Type: Bug
> Components: Build
> Affects Versions: 1.6
> Environment: all
> Reporter: Antoine Levy-Lambert
> Assigned To: Will Glass-Husain
> Priority: Minor
> Fix For: 1.6
>
> Attachments: patch.txt
>
>
> build.xml target package forces to use exactly JDK 1.4.
> Would it not be better to build with target=1.4, source=1.4 and to simply check that the JDK version is >= 1.4
> I will attach a patch to this effect.
> Regards,
> Antoine
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (VELOCITY-521) please do not force to use JDK 1.4
for running the package target in build.xml
Posted by "Antoine Levy-Lambert (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Levy-Lambert updated VELOCITY-521:
------------------------------------------
Hello Will,
As an indication, Ant 1.7.0 has been built under JDK 1.5 with source and target 1.2.
It runs perfectly under JDK 1.4. I am not sure whether we have had to change our code for 1.3 to make method calls go to the right JDK method. Ant does not run under 1.2 any more, but this is due to our implementation, not to compilation.
See these postings concerning the risks of compiling under 1.5
http://article.gmane.org/gmane.comp.jakarta.ant.devel/44616/
http://article.gmane.org/gmane.comp.jakarta.ant.devel/44751/
> please do not force to use JDK 1.4 for running the package target in build.xml
> ------------------------------------------------------------------------------
>
> Key: VELOCITY-521
> URL: https://issues.apache.org/jira/browse/VELOCITY-521
> Project: Velocity
> Issue Type: Bug
> Components: Build
> Affects Versions: 1.6
> Environment: all
> Reporter: Antoine Levy-Lambert
> Priority: Minor
> Attachments: patch.txt
>
>
> build.xml target package forces to use exactly JDK 1.4.
> Would it not be better to build with target=1.4, source=1.4 and to simply check that the JDK version is >= 1.4
> I will attach a patch to this effect.
> Regards,
> Antoine
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-521) please do not force to use JDK 1.4
for running the package target in build.xml
Posted by "Will Glass-Husain (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475619 ]
Will Glass-Husain commented on VELOCITY-521:
--------------------------------------------
Gump runs the package target? I hadn't realized that. I thought we only ran this for creating final distributions. Thanks for catching this.
Does it really work to set target=1.4, source=1.4 and have the resulting jar work with JDK 1.3, 1.4, 1.5 no matter which JDK you compile with?
> please do not force to use JDK 1.4 for running the package target in build.xml
> ------------------------------------------------------------------------------
>
> Key: VELOCITY-521
> URL: https://issues.apache.org/jira/browse/VELOCITY-521
> Project: Velocity
> Issue Type: Bug
> Components: Build
> Affects Versions: 1.6
> Environment: all
> Reporter: Antoine Levy-Lambert
> Priority: Minor
> Attachments: patch.txt
>
>
> build.xml target package forces to use exactly JDK 1.4.
> Would it not be better to build with target=1.4, source=1.4 and to simply check that the JDK version is >= 1.4
> I will attach a patch to this effect.
> Regards,
> Antoine
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Assigned: (VELOCITY-521) please do not force to use JDK 1.4
for running the package target in build.xml
Posted by "Will Glass-Husain (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Will Glass-Husain reassigned VELOCITY-521:
------------------------------------------
Assignee: Will Glass-Husain
> please do not force to use JDK 1.4 for running the package target in build.xml
> ------------------------------------------------------------------------------
>
> Key: VELOCITY-521
> URL: https://issues.apache.org/jira/browse/VELOCITY-521
> Project: Velocity
> Issue Type: Bug
> Components: Build
> Affects Versions: 1.6
> Environment: all
> Reporter: Antoine Levy-Lambert
> Assigned To: Will Glass-Husain
> Priority: Minor
> Attachments: patch.txt
>
>
> build.xml target package forces to use exactly JDK 1.4.
> Would it not be better to build with target=1.4, source=1.4 and to simply check that the JDK version is >= 1.4
> I will attach a patch to this effect.
> Regards,
> Antoine
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-521) please do not force to use JDK 1.4
for running the package target in build.xml
Posted by "Will Glass-Husain (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478428 ]
Will Glass-Husain commented on VELOCITY-521:
--------------------------------------------
ok, I'll pull it out. it seemed like a good idea at the time. I'd assumed that "ant dist" was only used by the release manager.
> please do not force to use JDK 1.4 for running the package target in build.xml
> ------------------------------------------------------------------------------
>
> Key: VELOCITY-521
> URL: https://issues.apache.org/jira/browse/VELOCITY-521
> Project: Velocity
> Issue Type: Bug
> Components: Build
> Affects Versions: 1.6
> Environment: all
> Reporter: Antoine Levy-Lambert
> Assigned To: Will Glass-Husain
> Priority: Minor
> Fix For: 1.6
>
> Attachments: patch.txt
>
>
> build.xml target package forces to use exactly JDK 1.4.
> Would it not be better to build with target=1.4, source=1.4 and to simply check that the JDK version is >= 1.4
> I will attach a patch to this effect.
> Regards,
> Antoine
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (VELOCITY-521) please do not force to use JDK 1.4
for running the package target in build.xml
Posted by "Antoine Levy-Lambert (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Levy-Lambert updated VELOCITY-521:
------------------------------------------
Attachment: patch.txt
I create this issue because velocity-engine stopped building in gump due to the strict JDK=1.4 restriction.
I found a workaround for gump by setting correct-java-version=true in the gump descriptor.
The solution proposed here is similar to the build of ant, where we build with source and target 1.2.
> please do not force to use JDK 1.4 for running the package target in build.xml
> ------------------------------------------------------------------------------
>
> Key: VELOCITY-521
> URL: https://issues.apache.org/jira/browse/VELOCITY-521
> Project: Velocity
> Issue Type: Bug
> Components: Build
> Affects Versions: 1.6
> Environment: all
> Reporter: Antoine Levy-Lambert
> Priority: Minor
> Attachments: patch.txt
>
>
> build.xml target package forces to use exactly JDK 1.4.
> Would it not be better to build with target=1.4, source=1.4 and to simply check that the JDK version is >= 1.4
> I will attach a patch to this effect.
> Regards,
> Antoine
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org