You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/02/10 09:05:19 UTC
[GitHub] [iotdb] ahuazhu opened a new issue #5030: TSFileDescriptor overwrite the config may lead to unexpected state
ahuazhu opened a new issue #5030:
URL: https://github.com/apache/iotdb/issues/5030
**Describe the bug**
The method TSFileDescriptor.loadProps() try to load parameters to overwrite the default values.
```
try {
....
conf.setMaxDegreeOfIndexNode(
Integer.parseInt(
properties.getProperty(
"max_degree_of_index_node", Integer.toString(conf.getMaxDegreeOfIndexNode()))));
conf.setMaxStringLength(
Integer.parseInt(
properties.getProperty(
"max_string_length", Integer.toString(conf.getMaxStringLength()))));
conf.setFloatPrecision(
Integer.parseInt(
properties.getProperty(
"float_precision", Integer.toString(conf.getFloatPrecision()))));
....
} catch (Exception e) {
logger.error("Loading settings {} failed", url, e);
} finally {
}
```
1. The way to fall back to the default value could be improved.
2. Considering if `Integer.parseInt(properties.getProperty("max_string_length", Integer.toString(conf.getMaxStringLength())))` throw `NumberFormatException` , these will lead to the situation: Parameters before *max_degree_of_index_node* are set correctly, but the successor ones are ignored. Ignoring and log the unexpected-parameters (fail over) or crash(fail fast) are common practices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on issue #5030: TSFileDescriptor overwrite the config may lead to unexpected state
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on issue #5030:
URL: https://github.com/apache/iotdb/issues/5030#issuecomment-1036012071
Hi, thanks for reporting and fixing this problem! Please add my wechat: qiaojialin1993, I will invite you to our group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on issue #5030: TSFileDescriptor overwrite the config may lead to unexpected state
Posted by GitBox <gi...@apache.org>.
HTHou commented on issue #5030:
URL: https://github.com/apache/iotdb/issues/5030#issuecomment-1034665921
Hi, which version is it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 closed issue #5030: TSFileDescriptor overwrite the config may lead to unexpected state
Posted by GitBox <gi...@apache.org>.
JackieTien97 closed issue #5030:
URL: https://github.com/apache/iotdb/issues/5030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou removed a comment on issue #5030: TSFileDescriptor overwrite the config may lead to unexpected state
Posted by GitBox <gi...@apache.org>.
HTHou removed a comment on issue #5030:
URL: https://github.com/apache/iotdb/issues/5030#issuecomment-1034665921
Hi, which version is it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] github-actions[bot] commented on issue #5030: TSFileDescriptor overwrite the config may lead to unexpected state
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #5030:
URL: https://github.com/apache/iotdb/issues/5030#issuecomment-1034665500
Hi, this is your first issue in IoTDB project. Thanks for your report. Welcome to join the community!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org