You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/05/24 07:23:00 UTC
[jira] [Commented] (AIRFLOW-2473) Fix wrong skip condition for
TransferTests
[ https://issues.apache.org/jira/browse/AIRFLOW-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488571#comment-16488571 ]
ASF subversion and git services commented on AIRFLOW-2473:
----------------------------------------------------------
Commit 357e46d27c9a90bba6f22a3dbe07aa5f7bc9146c in incubator-airflow's branch refs/heads/master from [~sekikn]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=357e46d ]
[AIRFLOW-2473] Fix wrong skip condition for TransferTests
This PR fixes wrong @skipUnlessImported which
decorates
TransferTests and does minor refactoring.
Closes #3411 from sekikn/AIRFLOW-2473
> Fix wrong skip condition for TransferTests
> ------------------------------------------
>
> Key: AIRFLOW-2473
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2473
> Project: Apache Airflow
> Issue Type: Bug
> Components: tests
> Reporter: Kengo Seki
> Assignee: Kengo Seki
> Priority: Minor
>
> tests.operators.operators:TransferTests has the following condition:
> {code}
> 228 @skipUnlessImported('airflow.operators.hive_operator', 'HiveOperator')
> 229 @skipUnlessImported('airflow.operators.postgres_operator', 'PostgresOperator')
> 230 class TransferTests(unittest.TestCase):
> 231 cluster = None
> (snip)
> {code}
> but it doesn't use {{PostgresOperator}} at all. In addition, it seems to have some unnecessary lines such as {{cluster = None}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)