You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by Fernando Wermus <fe...@gmail.com> on 2009/05/07 19:46:16 UTC
bug in swfObject.java --> http://cwiki.apache.org/WICKET/open-flash-chart-and-wicket.html
Hi all,
There is a small bug in swfObject in page:
http://cwiki.apache.org/WICKET/open-flash-chart-and-wicket.html.
When SwfObject receives more than one parameter, instead of adding a comma
between them, SwfObject omits it.
This mini bug could be fixed as follows:
private String buildDataObject(Map<String,String> data) {
final String quote = "'";
final String comma=",";
if (data != null && !data.isEmpty()) {
StringBuilder result = new StringBuilder();
result.append("{");
for (Map.Entry<String, String> e : getParameters().entrySet()) {
result.append(quote).append(e.getKey()).append(quote + ":" +
quote).append(e.getValue()).append(quote).append(comma);
}
result.deleteCharAt(result.length() - 1);
result.append("}");
return result.toString();
}
return "{}";
}
Besides, It doesn't work using modal windows :(.
--
Fernando Wermus.
www.linkedin.com/in/fernandowermus
http://mientretiempo.blogspot.com/
Re: bug in swfObject.java --> http://cwiki.apache.org/WICKET/open-flash-chart-and-wicket.html
Posted by Fernando Wermus <fe...@gmail.com>.
done
On Thu, May 7, 2009 at 12:48 PM, Maarten Bosteels
<mb...@gmail.com>wrote:
> It's a wiki page, you can fix it yourself.
> Yes you can !
>
> regards,
> Maarten
>
> On Thu, May 7, 2009 at 9:46 PM, Jeremy Thomerson
> <je...@wickettraining.com>wrote:
>
> > Please file a JIRA issue so that it doesn't get lost.
> >
> > --
> > Jeremy Thomerson
> > http://www.wickettraining.com
> >
> >
> >
> >
> > On Thu, May 7, 2009 at 12:46 PM, Fernando Wermus
> > <fe...@gmail.com> wrote:
> > > Hi all,
> > > There is a small bug in swfObject in page:
> > > http://cwiki.apache.org/WICKET/open-flash-chart-and-wicket.html.
> > >
> > > When SwfObject receives more than one parameter, instead of adding a
> > comma
> > > between them, SwfObject omits it.
> > >
> > > This mini bug could be fixed as follows:
> > >
> > >
> > > private String buildDataObject(Map<String,String> data) {
> > > final String quote = "'";
> > > final String comma=",";
> > > if (data != null && !data.isEmpty()) {
> > > StringBuilder result = new StringBuilder();
> > > result.append("{");
> > > for (Map.Entry<String, String> e : getParameters().entrySet()) {
> > > result.append(quote).append(e.getKey()).append(quote + ":" +
> > > quote).append(e.getValue()).append(quote).append(comma);
> > > }
> > > result.deleteCharAt(result.length() - 1);
> > > result.append("}");
> > > return result.toString();
> > > }
> > > return "{}";
> > > }
> > >
> > > Besides, It doesn't work using modal windows :(.
> > >
> > >
> > > --
> > > Fernando Wermus.
> > >
> > > www.linkedin.com/in/fernandowermus
> > > http://mientretiempo.blogspot.com/
> > >
> >
>
--
Fernando Wermus.
www.linkedin.com/in/fernandowermus
http://mientretiempo.blogspot.com/
Re: bug in swfObject.java --> http://cwiki.apache.org/WICKET/open-flash-chart-and-wicket.html
Posted by Maarten Bosteels <mb...@gmail.com>.
It's a wiki page, you can fix it yourself.
Yes you can !
regards,
Maarten
On Thu, May 7, 2009 at 9:46 PM, Jeremy Thomerson
<je...@wickettraining.com>wrote:
> Please file a JIRA issue so that it doesn't get lost.
>
> --
> Jeremy Thomerson
> http://www.wickettraining.com
>
>
>
>
> On Thu, May 7, 2009 at 12:46 PM, Fernando Wermus
> <fe...@gmail.com> wrote:
> > Hi all,
> > There is a small bug in swfObject in page:
> > http://cwiki.apache.org/WICKET/open-flash-chart-and-wicket.html.
> >
> > When SwfObject receives more than one parameter, instead of adding a
> comma
> > between them, SwfObject omits it.
> >
> > This mini bug could be fixed as follows:
> >
> >
> > private String buildDataObject(Map<String,String> data) {
> > final String quote = "'";
> > final String comma=",";
> > if (data != null && !data.isEmpty()) {
> > StringBuilder result = new StringBuilder();
> > result.append("{");
> > for (Map.Entry<String, String> e : getParameters().entrySet()) {
> > result.append(quote).append(e.getKey()).append(quote + ":" +
> > quote).append(e.getValue()).append(quote).append(comma);
> > }
> > result.deleteCharAt(result.length() - 1);
> > result.append("}");
> > return result.toString();
> > }
> > return "{}";
> > }
> >
> > Besides, It doesn't work using modal windows :(.
> >
> >
> > --
> > Fernando Wermus.
> >
> > www.linkedin.com/in/fernandowermus
> > http://mientretiempo.blogspot.com/
> >
>
Re: bug in swfObject.java --> http://cwiki.apache.org/WICKET/open-flash-chart-and-wicket.html
Posted by Jeremy Thomerson <je...@wickettraining.com>.
Please file a JIRA issue so that it doesn't get lost.
--
Jeremy Thomerson
http://www.wickettraining.com
On Thu, May 7, 2009 at 12:46 PM, Fernando Wermus
<fe...@gmail.com> wrote:
> Hi all,
> There is a small bug in swfObject in page:
> http://cwiki.apache.org/WICKET/open-flash-chart-and-wicket.html.
>
> When SwfObject receives more than one parameter, instead of adding a comma
> between them, SwfObject omits it.
>
> This mini bug could be fixed as follows:
>
>
> private String buildDataObject(Map<String,String> data) {
> final String quote = "'";
> final String comma=",";
> if (data != null && !data.isEmpty()) {
> StringBuilder result = new StringBuilder();
> result.append("{");
> for (Map.Entry<String, String> e : getParameters().entrySet()) {
> result.append(quote).append(e.getKey()).append(quote + ":" +
> quote).append(e.getValue()).append(quote).append(comma);
> }
> result.deleteCharAt(result.length() - 1);
> result.append("}");
> return result.toString();
> }
> return "{}";
> }
>
> Besides, It doesn't work using modal windows :(.
>
>
> --
> Fernando Wermus.
>
> www.linkedin.com/in/fernandowermus
> http://mientretiempo.blogspot.com/
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org