You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/11/09 15:11:01 UTC
[GitHub] [netbeans] mbien opened a new pull request, #4948: enable "sort document list by project" by default.
mbien opened a new pull request, #4948:
URL: https://github.com/apache/netbeans/pull/4948
as discussed on the [dev list](https://lists.apache.org/thread/g9w0038rdsksony6xyl4q42vnj4jrjk4), this proposes to tweak the default setting of the documents list dropdown of the editor.
option can be changed back in the main options window:
`tools -> options -> appearance -> document tabs -> "Sort opened documents list by default" checkbox`
This won't influence already made user settings, only the out-of-the-box default.
This area got some fixes #3299 and pending improvements recently.#4792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4948: enable "sort document list by project" by default.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#issuecomment-1465311416
I was wondering about that before: if multitabs can do everything what o.n.swing.tabcontrol can do, why are there still two implementations in use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4948: enable "sort document list by project" by default.
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#discussion_r1056648038
##########
platform/core.multitabs/src/org/netbeans/core/multitabs/impl/TabDataRenderer.java:
##########
@@ -238,10 +238,10 @@ public void paint( Graphics g ) {
switch (tabsLocation) {
default:
case JTabbedPane.TOP:
- g.fillRect(0, rect.height - underlineHeight, rect.width, underlineHeight);
+ g.fillRect(0, 0, rect.width, underlineHeight);
break;
case JTabbedPane.BOTTOM:
- g.fillRect(0, 0, rect.width, underlineHeight);
+ g.fillRect(0, rect.height - underlineHeight, rect.width, underlineHeight);
break;
Review Comment:
roger. I *think* i know what you mean. Going to take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #4948: enable "sort document list by project" by default.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#issuecomment-1367293005
I don't think multitabs is ready to become the default tab renderer implementation yet. There were a lot of improvements to the FlatLAF renderer that should be ported over to multitabs first:
* https://github.com/apache/netbeans/pull/4286 (besides the underlineAtTop part)
* https://github.com/apache/netbeans/pull/4335
* https://github.com/apache/netbeans/pull/4349
(Example adjustments that are missing on multitabs: left editor border on 150% HiDPI scaling, lighter text color on non-active tabs, vertical alignment of text and X buttons against Project/Files/Services sidebar and the document tab area, adjustments to horizontal margins around text and X buttons etc.)
I can take a whack at this at some point, though it may take me a while to get around to it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4948: enable "sort document list by project" by default.
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#discussion_r1054886327
##########
platform/core.multitabs/src/org/netbeans/core/multitabs/impl/TabDataRenderer.java:
##########
@@ -238,10 +238,10 @@ public void paint( Graphics g ) {
switch (tabsLocation) {
default:
case JTabbedPane.TOP:
- g.fillRect(0, rect.height - underlineHeight, rect.width, underlineHeight);
+ g.fillRect(0, 0, rect.width, underlineHeight);
break;
case JTabbedPane.BOTTOM:
- g.fillRect(0, 0, rect.width, underlineHeight);
+ g.fillRect(0, rect.height - underlineHeight, rect.width, underlineHeight);
break;
Review Comment:
@neilcsmith-net @eirikbakke forgot to mention that I did swap the case ops as instructed.
It seems to have the desired effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4948: enable "sort document list by project" by default.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#issuecomment-1317441391
converted it back to draft so that nobody can merge it by accident.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] enable "sort document list by project" by default. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#issuecomment-1757351513
removed milestone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4948: enable "sort document list by project" by default.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#issuecomment-1317462910
And this seems to cover all the settings where they take over - https://github.com/apache/netbeans/blob/master/platform/core.multitabs/src/org/netbeans/core/multitabs/prefs/SettingsImpl.java#L57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on a diff in pull request #4948: enable "sort document list by project" by default.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on code in PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#discussion_r1056534714
##########
platform/core.multitabs/src/org/netbeans/core/multitabs/impl/TabDataRenderer.java:
##########
@@ -238,10 +238,10 @@ public void paint( Graphics g ) {
switch (tabsLocation) {
default:
case JTabbedPane.TOP:
- g.fillRect(0, rect.height - underlineHeight, rect.width, underlineHeight);
+ g.fillRect(0, 0, rect.width, underlineHeight);
break;
case JTabbedPane.BOTTOM:
- g.fillRect(0, 0, rect.width, underlineHeight);
+ g.fillRect(0, rect.height - underlineHeight, rect.width, underlineHeight);
break;
Review Comment:
@mbien thanks, but thinking about this more, it would be better to swap the underline position based on the value of `EditorTab.underlineAtTop` as used at https://github.com/apache/netbeans/blob/master/platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/ui/FlatEditorTabCellRenderer.java#L68 ? That should keep it consistent.
For same reason, I'd probably swap the horizontal tabs line position on the same flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4948: enable "sort document list by project" by default.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#discussion_r1125580603
##########
platform/core.multitabs/src/org/netbeans/core/multitabs/impl/TabDataRenderer.java:
##########
@@ -238,10 +238,10 @@ public void paint( Graphics g ) {
switch (tabsLocation) {
default:
case JTabbedPane.TOP:
- g.fillRect(0, rect.height - underlineHeight, rect.width, underlineHeight);
+ g.fillRect(0, 0, rect.width, underlineHeight);
break;
case JTabbedPane.BOTTOM:
- g.fillRect(0, 0, rect.width, underlineHeight);
+ g.fillRect(0, rect.height - underlineHeight, rect.width, underlineHeight);
break;
Review Comment:
I didn't touch left/right since the regular tabs don't change the line positioning there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4948: enable "sort document list by project" by default.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#issuecomment-1454945474
added dev build label so that it is easier to test, build is linked on the build summary page for 7 days.
@eirikbakke since you did the tweaks to the regular tabs, would you like to do them for those tabs here too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4948: enable "sort document list by project" by default.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#issuecomment-1505729223
moved to NB19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #4948: enable "sort document list by project" by default.
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#issuecomment-1465314241
@mbien I don't know the history of the two implementations, but it seems like the regular tabcontrol implementation was much easier to customize for skinning purposes, so that's the implementation that was customized in all the old LAFs.
If at some point we get multitabs to support all the FlatLAF options that now exist for regular tabs, we could probably switch to multitabs in all cases for FlatLAF, and effectively deprecate the other one. (Unless multitabs turns out to have problems we aren't currently aware of.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4948: enable "sort document list by project" by default.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#issuecomment-1317431045
@eirikbakke thats funny. I was wondering who quietly changed the tabs back, wouldn't have guessed that it has something to do with this setting :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #4948: enable "sort document list by project" by default.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#issuecomment-1317423408
This affects the appearance of tabs, not just the document list dropdown. Probably the UI tweaks that were done in https://github.com/apache/netbeans/pull/4286 should be adapted to the "Sort opened document list by project" mode as well before making this the default.
<img width="963" alt="sortdoc" src="https://user-images.githubusercontent.com/886243/202255808-42974ab4-6415-484f-a661-d12549ed89bb.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4948: enable "sort document list by project" by default.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#issuecomment-1317457402
I think the problematic code is here - https://github.com/apache/netbeans/blob/master/platform/core.multitabs/src/org/netbeans/core/multitabs/impl/TabDataRenderer.java#L234 And I think it's currently not LAF-specific, and the position changes depending on where the tabs are located. Still, maybe as quick fix could just switch "under"line position for top and bottom tab positions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #4948: enable "sort document list by project" by default.
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#issuecomment-1477708396
@neilcsmith-net Yeah, I think multitabs could only ever become the default for FlatLAF specifically. Regular tabs could be "deprecated" only in the sense that LAFs other than FlatLAF would be "deprecated".
> I'm not sure if we can make multitabs delegate better to the laf tabs so that most fixes can just go in there?
I suspect this might be difficult, and perhaps not necessary. If multitabs can be skinned via UIDefaults properties, like FlatLAF, then all future skinning of the tab components could be done this way, rather than by changing LAF-specific code.
I also wonder to what degree we hope to continue maintaining the old non-flatLAF LAFs. (e.g. GTK LAF, Windows LAF, MacOS/Aqua LAF). Myself, I've completely moved over to FlatLAF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4948: enable "sort document list by project" by default.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#discussion_r1125580132
##########
platform/core.multitabs/src/org/netbeans/core/multitabs/impl/TabDataRenderer.java:
##########
@@ -238,10 +238,10 @@ public void paint( Graphics g ) {
switch (tabsLocation) {
default:
case JTabbedPane.TOP:
- g.fillRect(0, rect.height - underlineHeight, rect.width, underlineHeight);
+ g.fillRect(0, 0, rect.width, underlineHeight);
break;
case JTabbedPane.BOTTOM:
- g.fillRect(0, 0, rect.width, underlineHeight);
+ g.fillRect(0, rect.height - underlineHeight, rect.width, underlineHeight);
break;
Review Comment:
implemented it finally. When the tab is on the bottom it is rendered on the bottom if `underlineAtTop` is set since everything is bottom up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4948: enable "sort document list by project" by default.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#issuecomment-1317435632
IIRC it uses the multi-row tab renderer in this case, and code for those needs looking at to work properly with #4286
So, sorry, -1 to this change until we can fix that issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4948: enable "sort document list by project" by default.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#discussion_r1125580132
##########
platform/core.multitabs/src/org/netbeans/core/multitabs/impl/TabDataRenderer.java:
##########
@@ -238,10 +238,10 @@ public void paint( Graphics g ) {
switch (tabsLocation) {
default:
case JTabbedPane.TOP:
- g.fillRect(0, rect.height - underlineHeight, rect.width, underlineHeight);
+ g.fillRect(0, 0, rect.width, underlineHeight);
break;
case JTabbedPane.BOTTOM:
- g.fillRect(0, 0, rect.width, underlineHeight);
+ g.fillRect(0, rect.height - underlineHeight, rect.width, underlineHeight);
break;
Review Comment:
implemented it finally. When the tab is on the bottom it is rendered on the bottom if `underlineAtTop` is set since everything is bottom up :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #4948: enable "sort document list by project" by default.
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#issuecomment-1465309713
@mbien I started looking at it. Applying the past improvements to multitabs is going to be a somewhat bigger project, as it's a completely different implementation/code path with more generic functionality (multiple rows, group by project, tabs on left/right/bottom etc.). I might get back to it later.
For reference, the logic for when multitabs is used is here:
[org.netbeans.core.multitabs.prefs.SettingsImpl.isEnabled](https://github.com/apache/netbeans/blob/4b7776a679963cd2d0797fd64fa11f8decda3c32/platform/core.multitabs/src/org/netbeans/core/multitabs/prefs/SettingsImpl.java#L57)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4948: enable "sort document list by project" by default.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#issuecomment-1367583181
@eirikbakke ok, I convert this to draft so that nobody merges it by accident.
If anyone wants to close this completely feel free to do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4948: enable "sort document list by project" by default.
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #4948:
URL: https://github.com/apache/netbeans/pull/4948#issuecomment-1477555997
> If at some point we get multitabs to support all the FlatLAF options that now exist for regular tabs, we could probably switch to multitabs in all cases for FlatLAF, and effectively deprecate the other one. (Unless multitabs turns out to have problems we aren't currently aware of.)
Switching to multitabs in all cases within the IDE might be good. But we need to be careful that it's an optional part of the platform so make sure we don't do anything that "breaks" cases where it's not included.
I'm not sure if we can make multitabs delegate better to the laf tabs so that most fixes can just go in there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists