[GitHub] [arrow] wjones127 commented on a diff in pull request #13665: ARROW-17100: [C++][Parquet] Fix backwards compatibility for ParquetV2 data pages written prior to 3.0.0 per ARROW-10353

[GitBox <gi...@apache.org>]

wjones127 commented on code in PR #13665:
URL: https://github.com/apache/arrow/pull/13665#discussion_r927995829


##########
cpp/src/parquet/arrow/arrow_reader_writer_test.cc:
##########
@@ -3943,6 +3943,19 @@ TEST(TestArrowReaderAdHoc, WriteBatchedNestedNullableStringColumn) {
   ::arrow::AssertTablesEqual(*expected, *actual, /*same_chunk_layout=*/false);
 }
 
+TEST(TestArrowReaderAdHoc, OldDataPageV2) {
+  // ARROW-17100
+  const char* c_root = std::getenv("ARROW_TEST_DATA");
+  if (!c_root) {
+    GTEST_SKIP() << "ARROW_TEST_DATA not set.";
+  }

Review Comment:
   I think the feeling was it was Arrow C++ specific because it's not *technically* a valid parquet file but we wanted to be able to read it anyways for backwards compatibility. My understanding of the `parquet-testing` repo was it contains files that all readers should either definitely support or definitely not. But I'm open to moving if I'm misunderstanding the purpose of `parquet-testing`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org