You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Nicolas Malin (JIRA)" <ji...@apache.org> on 2012/05/03 12:02:50 UTC
[jira] [Created] (OFBIZ-4850) When Use Add Tax button on invoice
summary, duplicate existed tax line
Nicolas Malin created OFBIZ-4850:
------------------------------------
Summary: When Use Add Tax button on invoice summary, duplicate existed tax line
Key: OFBIZ-4850
URL: https://issues.apache.org/jira/browse/OFBIZ-4850
Project: OFBiz
Issue Type: Bug
Components: accounting
Affects Versions: SVN trunk
Reporter: Nicolas Malin
Priority: Minor
When you click on "add tax" button on invoice summary, the service create a invoice item list and generate sale tax by list iterate.
Two problem :
1. When you have 3 lignes with one without productId, the service may skip to set tax on valid invoice item
2. If sale tax is present, the service duplicate it and generate a tax on the tax (since a productId is on the line).
I propose a patch to :
1. remove all exiting tax associate to a product before analyze
2. take only invoice item with a productId
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4850) When Use Add Tax button on invoice
summary, duplicate existed tax line
Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Malin updated OFBIZ-4850:
---------------------------------
Attachment: OFBIZ-4850.patch
I slim some if code, to help the reading code
> When Use Add Tax button on invoice summary, duplicate existed tax line
> -----------------------------------------------------------------------
>
> Key: OFBIZ-4850
> URL: https://issues.apache.org/jira/browse/OFBIZ-4850
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Priority: Minor
> Attachments: OFBIZ-4850.patch
>
>
> When you click on "add tax" button on invoice summary, the service create a invoice item list and generate sale tax by list iterate.
> Two problem :
> 1. When you have 3 lignes with one without productId, the service may skip to set tax on valid invoice item
> 2. If sale tax is present, the service duplicate it and generate a tax on the tax (since a productId is on the line).
> I propose a patch to :
> 1. remove all exiting tax associate to a product before analyze
> 2. take only invoice item with a productId
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira