You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/21 06:46:14 UTC
[GitHub] [spark] cloud-fan opened a new pull request #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
cloud-fan opened a new pull request #28281:
URL: https://github.com/apache/spark/pull/28281
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
override the `sql` method of `StringTrim`, `StringTrimLeft` and `StringTrimRight`, to use the standard SQL syntax.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
The current implementation is wrong. It gives you a SQL string that returns different result.
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
new tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-616994852
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121568/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-617054459
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28281:
URL: https://github.com/apache/spark/pull/28281#discussion_r411916697
##########
File path: sql/core/src/test/resources/sql-tests/results/string-functions.sql.out
##########
@@ -204,65 +204,73 @@ struct<substring(Spark SQL, 5, 1):string>
k
+-- !query
+SELECT trim(" xyz "), ltrim(" xyz "), rtrim(" xyz ")
+-- !query schema
+struct<trim( xyz ):string,ltrim( xyz ):string,rtrim( xyz ):string>
+-- !query output
+xyz xyz xyz
+
+
-- !query
SELECT trim(BOTH 'xyz' FROM 'yxTomxx'), trim('xyz' FROM 'yxTomxx')
-- !query schema
-struct<trim(yxTomxx, xyz):string,trim(yxTomxx, xyz):string>
+struct<TRIM(BOTH xyz FROM yxTomxx):string,TRIM(BOTH xyz FROM yxTomxx):string>
Review comment:
Got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-617180649
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-617049181
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-617009086
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-617053811
**[Test build #121578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121578/testReport)** for PR 28281 at commit [`47f9d03`](https://github.com/apache/spark/commit/47f9d0369802a102452d599ab44e3041c798a2b4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-616987400
cc @dongjoon-hyun @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-617049069
**[Test build #121575 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121575/testReport)** for PR 28281 at commit [`e3e2f14`](https://github.com/apache/spark/commit/e3e2f141e196a3a6f94bb3e4c4cbaf9a4d127024).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-617054459
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-617009086
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-617034755
@dongjoon-hyun I think this bug exists the first day we add `TRIM` or the `sql` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-617053811
**[Test build #121578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121578/testReport)** for PR 28281 at commit [`47f9d03`](https://github.com/apache/spark/commit/47f9d0369802a102452d599ab44e3041c798a2b4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-617008416
**[Test build #121575 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121575/testReport)** for PR 28281 at commit [`e3e2f14`](https://github.com/apache/spark/commit/e3e2f141e196a3a6f94bb3e4c4cbaf9a4d127024).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-617007313
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-616994795
**[Test build #121568 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121568/testReport)** for PR 28281 at commit [`e3e2f14`](https://github.com/apache/spark/commit/e3e2f141e196a3a6f94bb3e4c4cbaf9a4d127024).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan edited a comment on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
cloud-fan edited a comment on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-617034755
@dongjoon-hyun I think this bug exists the first day we add `TRIM` or the `sql` method. We should fix it in 2.4 as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-617008416
**[Test build #121575 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121575/testReport)** for PR 28281 at commit [`e3e2f14`](https://github.com/apache/spark/commit/e3e2f141e196a3a6f94bb3e4c4cbaf9a4d127024).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-616994839
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-616988577
**[Test build #121568 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121568/testReport)** for PR 28281 at commit [`e3e2f14`](https://github.com/apache/spark/commit/e3e2f141e196a3a6f94bb3e4c4cbaf9a4d127024).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-617049181
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-616989043
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-617180649
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-617736364
The backport PR: https://github.com/apache/spark/pull/28299
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-616994839
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-616989043
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-617049197
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121575/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-617335295
cc @holdenk since she is the release manager for 2.4.6.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-617335032
Could you make a backporting PR to branch-2.4?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-617179442
**[Test build #121578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121578/testReport)** for PR 28281 at commit [`47f9d03`](https://github.com/apache/spark/commit/47f9d0369802a102452d599ab44e3041c798a2b4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-616988105
Thank you for pinging me, @cloud-fan .
Then, does this affect `branch-2.4`, too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28281: [SPARK-31503][SQL] fix the SQL string of the TRIM functions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28281:
URL: https://github.com/apache/spark/pull/28281#issuecomment-616988577
**[Test build #121568 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121568/testReport)** for PR 28281 at commit [`e3e2f14`](https://github.com/apache/spark/commit/e3e2f141e196a3a6f94bb3e4c4cbaf9a4d127024).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org