[GitHub] [arrow-datafusion] HaoYang670 opened a new issue, #4431: Remove the schema checking from `CrossJoinExec::try_new`

[GitBox <gi...@apache.org>]

HaoYang670 opened a new issue, #4431:
URL: https://github.com/apache/arrow-datafusion/issues/4431

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   https://github.com/apache/arrow-datafusion/blob/49166ea55f317722ab7a37fbfc253bcd497c1672/datafusion/core/src/physical_plan/joins/cross_join.rs#L67-L92
   We don't need to check the schemas when doing `cross join` because the join key is always empty.
   
   **Describe the solution you'd like**
   Remove the checking and update the return type of the function. Also, it is better to rename the function as `new`
   
   **Describe alternatives you've considered**
   A clear and concise description of any alternative solutions or features you've considered.
   We could not do this.
   
   **Additional context**
   Add any other context or screenshots about the feature request here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb closed issue #4431: Remove the schema checking from `CrossJoinExec::try_new`

[GitBox <gi...@apache.org>]

alamb closed issue #4431: Remove the schema checking from `CrossJoinExec::try_new`
URL: https://github.com/apache/arrow-datafusion/issues/4431


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org