You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/21 14:34:36 UTC
[GitHub] [kafka] cadonna opened a new pull request, #12323: MINOR: Fix static mock usage in ProcessorNodeMetricsTest
cadonna opened a new pull request, #12323:
URL: https://github.com/apache/kafka/pull/12323
Before this PR the calls to StreamsMetricsImpl.addInvocationRateAndCountToSensor()
were just calls and not a verification on the mock. This miss happened
during the switch from EasyMock to Mockito.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna merged pull request #12323: MINOR: Fix static mock usage in ProcessorNodeMetricsTest
Posted by GitBox <gi...@apache.org>.
cadonna merged PR #12323:
URL: https://github.com/apache/kafka/pull/12323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #12323: MINOR: Fix static mock usage in ProcessorNodeMetricsTest
Posted by GitBox <gi...@apache.org>.
cadonna commented on PR #12323:
URL: https://github.com/apache/kafka/pull/12323#issuecomment-1162753980
Good call!
The mockito docs say:
> When using the inline mock maker, it is possible to mock static method invocations within the current thread and a user-defined scope. This way, Mockito assures that concurrently and sequentially running tests do not interfere.
Additionally, I put the static mock into try-with-resource statements to limit the scope of the mock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org