You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/03/20 21:04:05 UTC

[GitHub] [cassandra] michaelsembwever commented on a change in pull request #1488: CASSANDRA-17427 Unit test improvements

michaelsembwever commented on a change in pull request #1488:
URL: https://github.com/apache/cassandra/pull/1488#discussion_r830672869



##########
File path: src/java/org/apache/cassandra/io/util/PathUtils.java
##########
@@ -63,14 +63,16 @@
     private static final Set<StandardOpenOption> READ_WRITE_OPTIONS = unmodifiableSet(EnumSet.of(READ, WRITE, CREATE));
     private static final FileAttribute<?>[] NO_ATTRIBUTES = new FileAttribute[0];
 
+    private static final boolean USE_NIX_RECURSIVE_DELETE = CassandraRelevantProperties.USE_NIX_RECURSIVE_DELETE.getBoolean();

Review comment:
       fair enough. maybe a comment that we eventually want to hard code it to true? 
   (and how we will encourage testing/verification of it?)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org