You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "wenfeiyi666 (Jira)" <ji...@apache.org> on 2021/02/08 09:53:00 UTC

[jira] [Assigned] (HBASE-24792) return value of LogRoller.walRollFinished may be wrong

     [ https://issues.apache.org/jira/browse/HBASE-24792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

wenfeiyi666 reassigned HBASE-24792:
-----------------------------------

    Assignee:     (was: wenfeiyi666)

> return value of LogRoller.walRollFinished may be wrong
> ------------------------------------------------------
>
>                 Key: HBASE-24792
>                 URL: https://issues.apache.org/jira/browse/HBASE-24792
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 3.0.0-alpha-1, 2.3.1, 2.2.6
>            Reporter: wenfeiyi666
>            Priority: Minor
>             Fix For: 3.0.0-alpha-1, 2.3.5
>
>
> The LogRoller.walRollFinished impl is already buggy. This just checks the status of the boolean. Once we start a roll on a WAL, we reset the boolean (Even before patch HBASE-24665). So it is not clearly telling anything abt the roll status. This can return true even while an active wal roll is going on.
> We might need another boolean in Controller which clearly tracks whether we are ongoing a roll.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)