You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@phoenix.apache.org by ja...@apache.org on 2015/06/04 23:47:15 UTC
phoenix git commit: PHOENIX-1987 SIGN built-in function should be
order preserving (Shuxiong Ye)
Repository: phoenix
Updated Branches:
refs/heads/4.4-HBase-0.98 1656c9f34 -> da3ec045c
PHOENIX-1987 SIGN built-in function should be order preserving (Shuxiong Ye)
Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo
Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/da3ec045
Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/da3ec045
Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/da3ec045
Branch: refs/heads/4.4-HBase-0.98
Commit: da3ec045cf554a9ffd577b4bc6495237f6f45073
Parents: 1656c9f
Author: James Taylor <ja...@apache.org>
Authored: Thu Jun 4 14:24:06 2015 -0700
Committer: James Taylor <ja...@apache.org>
Committed: Thu Jun 4 14:45:46 2015 -0700
----------------------------------------------------------------------
.../org/apache/phoenix/expression/function/SignFunction.java | 5 +++++
.../java/org/apache/phoenix/expression/SignFunctionTest.java | 3 ++-
2 files changed, 7 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/phoenix/blob/da3ec045/phoenix-core/src/main/java/org/apache/phoenix/expression/function/SignFunction.java
----------------------------------------------------------------------
diff --git a/phoenix-core/src/main/java/org/apache/phoenix/expression/function/SignFunction.java b/phoenix-core/src/main/java/org/apache/phoenix/expression/function/SignFunction.java
index 0b470f8..a11eaff 100644
--- a/phoenix-core/src/main/java/org/apache/phoenix/expression/function/SignFunction.java
+++ b/phoenix-core/src/main/java/org/apache/phoenix/expression/function/SignFunction.java
@@ -71,4 +71,9 @@ public class SignFunction extends ScalarFunction {
public String getName() {
return NAME;
}
+
+ @Override
+ public OrderPreserving preservesOrder() {
+ return OrderPreserving.YES;
+ }
}
http://git-wip-us.apache.org/repos/asf/phoenix/blob/da3ec045/phoenix-core/src/test/java/org/apache/phoenix/expression/SignFunctionTest.java
----------------------------------------------------------------------
diff --git a/phoenix-core/src/test/java/org/apache/phoenix/expression/SignFunctionTest.java b/phoenix-core/src/test/java/org/apache/phoenix/expression/SignFunctionTest.java
index 37d6e1d..e4a5f80 100644
--- a/phoenix-core/src/test/java/org/apache/phoenix/expression/SignFunctionTest.java
+++ b/phoenix-core/src/test/java/org/apache/phoenix/expression/SignFunctionTest.java
@@ -54,7 +54,8 @@ public class SignFunctionTest {
Expression signFunction = new SignFunction(expressions);
ImmutableBytesWritable ptr = new ImmutableBytesWritable();
signFunction.evaluate(null, ptr);
- Integer result = (Integer) signFunction.getDataType().toObject(ptr);
+ Integer result =
+ (Integer) signFunction.getDataType().toObject(ptr, signFunction.getSortOrder());
assertTrue(result.compareTo(expected) == 0);
}