[GitHub] [incubator-kyuubi] zhouyifan279 commented on a diff in pull request #3665: [KYUUBI #3608][Subtask] Get table owner from CatalogTable

[GitBox <gi...@apache.org>]

zhouyifan279 commented on code in PR #3665:
URL: https://github.com/apache/incubator-kyuubi/pull/3665#discussion_r999543540


##########
extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RangerSparkExtensionSuite.scala:
##########
@@ -672,6 +672,36 @@ abstract class RangerSparkExtensionSuite extends AnyFunSuite
     }
     doAs("admin", assert(sql("show tables from global_temp").collect().length == 0))
   }
+
+  test("[KYUUBI #3607] Support {OWNER} variable defined in Ranger Policy") {
+    // For now, only hive catalog is supported
+    assume(catalogImpl == "hive")

Review Comment:
   After the Umbrella issue is completed, {OWNER} variable support will not be restricted to hive catalog.
   It should work with any `CatalogExtension` providing owner property.
   Mabe it is better to cancel test by whether we can get table owner.
   
   ``` 
       val (inputs, _) = PrivilegesBuilder.build(sql(select).queryExecution.analyzed, spark)
       assume(inputs.nonEmpty && inputs.head.owner.isDefined)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org