[GitHub] [trafficserver] whutwhu opened a new pull request #6821: change overridable var type for proxy.config.http.server_session_sharing.match from int to string

[GitBox <gi...@apache.org>]

whutwhu opened a new pull request #6821:
URL: https://github.com/apache/trafficserver/pull/6821


   We find a problem when we set overridable config proxy.config.http.server_session_sharing.match in the remap rule. That config type is defined as string (https://github.com/apache/trafficserver/blob/master/mgmt/RecordsConfig.cc#L375), which is same with ATS manual, but it’s also defined as integer if we override it from remap rule(https://github.com/apache/trafficserver/blob/master/src/shared/overridable_txn_vars.cc#L104), and only integer format is supported in the remap plugin due to this code (https://github.com/apache/trafficserver/blob/master/plugins/conf_remap/conf_remap.cc#L98).
   
   We discussed it in the slack channel, to make things consistency, we’re planning changing the override type for this config to string, and only string format would be used in remap rule to override this config. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] whutwhu closed pull request #6821: change overridable var type for proxy.config.http.server_session_sharing.match from int to string

[GitBox <gi...@apache.org>]

whutwhu closed pull request #6821:
URL: https://github.com/apache/trafficserver/pull/6821


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org