You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/07/14 10:39:34 UTC

[GitHub] [incubator-tvm] liangfu opened a new pull request #6053: [BUGFIX] Fix a number of memory leaks

liangfu opened a new pull request #6053:
URL: https://github.com/apache/incubator-tvm/pull/6053


   This PR fixed a number of memory leaks implemented in C++, where memory allocations should have been handled with unique_ptr.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #6053: [BUGFIX] Fix a number of memory leaks

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6053:
URL: https://github.com/apache/incubator-tvm/pull/6053#issuecomment-658416101


   Thanks @liangfu , we intentionally do not free these functions, to avoid the de-allocation a python side PackedFunc in global destruction, so these code are intended as the comment suggests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] liangfu closed pull request #6053: [BUGFIX] Fix a number of memory leaks

Posted by GitBox <gi...@apache.org>.
liangfu closed pull request #6053:
URL: https://github.com/apache/incubator-tvm/pull/6053


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #6053: [BUGFIX] Fix a number of memory leaks

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6053:
URL: https://github.com/apache/incubator-tvm/pull/6053#issuecomment-658840741


   It was a flaky error rather than a normal one


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] liangfu commented on pull request #6053: [BUGFIX] Fix a number of memory leaks

Posted by GitBox <gi...@apache.org>.
liangfu commented on pull request #6053:
URL: https://github.com/apache/incubator-tvm/pull/6053#issuecomment-658572342


   Thanks for the explanation @tqchen. I would like to close this for now. However, I'm not quite sure why all ci tests passed with the proposed change, or do we have a python test script that require such memory unreleased?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org