[jira] [Commented] (FLINK-3794) Add checks for unsupported operations in streaming table API

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251771#comment-15251771 ] 

ASF GitHub Bot commented on FLINK-3794:
---------------------------------------

GitHub user vasia opened a pull request:

    https://github.com/apache/flink/pull/1921

    [FLINK-3794] add checks for unsupported operations in streaming table API

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [X] General
      - The pull request references the related JIRA issue
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [X] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    groupBy, distinct, join, and aggregation inside select will now fail before translation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vasia/flink flink-3794

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1921.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1921
    
----
commit 6a2f21a1f20933558635f89db03fcd03a180ca00
Author: vasia <va...@apache.org>
Date:   2016-04-21T10:17:32Z

    [FLINK-3794] add checks for unsupported operations in streaming table API

----


> Add checks for unsupported operations in streaming table API
> ------------------------------------------------------------
>
>                 Key: FLINK-3794
>                 URL: https://issues.apache.org/jira/browse/FLINK-3794
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API
>    Affects Versions: 1.1.0
>            Reporter: Vasia Kalavri
>            Assignee: Vasia Kalavri
>
> Unsupported operations on streaming tables currently fail during plan translation. It would be nicer to add checks in the Table API methods and fail with an informative message that the operation is not supported. The operations that are not currently supported are:
> - aggregations inside select
> - groupBy
> - distinct
> - join
> We can simply check if the Table's environment is a streaming environment and throw an unsupported operation exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)