You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org> on 2008/11/26 12:12:44 UTC
[jira] Created: (HADOOP-4732) connectionTimeout and readTimeout
are passed in wrong order in ReduceTask.java
connectionTimeout and readTimeout are passed in wrong order in ReduceTask.java
-------------------------------------------------------------------------------
Key: HADOOP-4732
URL: https://issues.apache.org/jira/browse/HADOOP-4732
Project: Hadoop Core
Issue Type: Bug
Components: mapred
Reporter: Amareshwari Sriramadasu
Assignee: Amareshwari Sriramadasu
Priority: Minor
Fix For: 0.20.0
In ReduceTask.java, The parameters for method calls for getInputStream(URLConnection connection, int connectionTimeout, int readTimeout) should be in that order. Now it is
{code}
InputStream input = getInputStream(connection, DEFAULT_READ_TIMEOUT,
STALLED_COPY_TIMEOUT);
{code}
It works now because both DEFAULT_READ_TIMEOUT and STALLED_COPY_TIMEOUT have the same value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4732) connectionTimeout and readTimeout
are passed in wrong order in ReduceTask.java
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651690#action_12651690 ]
Hadoop QA commented on HADOOP-4732:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12394733/patch-4732.txt
against trunk revision 721415.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3667/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3667/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3667/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3667/console
This message is automatically generated.
> connectionTimeout and readTimeout are passed in wrong order in ReduceTask.java
> -------------------------------------------------------------------------------
>
> Key: HADOOP-4732
> URL: https://issues.apache.org/jira/browse/HADOOP-4732
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: patch-4732.txt
>
>
> In ReduceTask.java, The parameters for method calls for getInputStream(URLConnection connection, int connectionTimeout, int readTimeout) should be in that order. Now it is
> {code}
> InputStream input = getInputStream(connection, DEFAULT_READ_TIMEOUT,
> STALLED_COPY_TIMEOUT);
> {code}
> It works now because both DEFAULT_READ_TIMEOUT and STALLED_COPY_TIMEOUT have the same value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4732) connectionTimeout and readTimeout
are passed in wrong order in ReduceTask.java
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-4732:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
+1 Good catch.
I just committed this. Thanks, Amareshwari
> connectionTimeout and readTimeout are passed in wrong order in ReduceTask.java
> -------------------------------------------------------------------------------
>
> Key: HADOOP-4732
> URL: https://issues.apache.org/jira/browse/HADOOP-4732
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: patch-4732.txt
>
>
> In ReduceTask.java, The parameters for method calls for getInputStream(URLConnection connection, int connectionTimeout, int readTimeout) should be in that order. Now it is
> {code}
> InputStream input = getInputStream(connection, DEFAULT_READ_TIMEOUT,
> STALLED_COPY_TIMEOUT);
> {code}
> It works now because both DEFAULT_READ_TIMEOUT and STALLED_COPY_TIMEOUT have the same value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4732) connectionTimeout and readTimeout
are passed in wrong order in ReduceTask.java
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652122#action_12652122 ]
Hudson commented on HADOOP-4732:
--------------------------------
Integrated in Hadoop-trunk #675 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/675/])
. Pass connection and read timeouts in the correct order when
setting up fetch in reduce. Contributed by Amareshwari Sriramadasu.
> connectionTimeout and readTimeout are passed in wrong order in ReduceTask.java
> -------------------------------------------------------------------------------
>
> Key: HADOOP-4732
> URL: https://issues.apache.org/jira/browse/HADOOP-4732
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: patch-4732.txt
>
>
> In ReduceTask.java, The parameters for method calls for getInputStream(URLConnection connection, int connectionTimeout, int readTimeout) should be in that order. Now it is
> {code}
> InputStream input = getInputStream(connection, DEFAULT_READ_TIMEOUT,
> STALLED_COPY_TIMEOUT);
> {code}
> It works now because both DEFAULT_READ_TIMEOUT and STALLED_COPY_TIMEOUT have the same value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4732) connectionTimeout and readTimeout
are passed in wrong order in ReduceTask.java
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-4732:
--------------------------------------------
Status: Patch Available (was: Open)
> connectionTimeout and readTimeout are passed in wrong order in ReduceTask.java
> -------------------------------------------------------------------------------
>
> Key: HADOOP-4732
> URL: https://issues.apache.org/jira/browse/HADOOP-4732
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: patch-4732.txt
>
>
> In ReduceTask.java, The parameters for method calls for getInputStream(URLConnection connection, int connectionTimeout, int readTimeout) should be in that order. Now it is
> {code}
> InputStream input = getInputStream(connection, DEFAULT_READ_TIMEOUT,
> STALLED_COPY_TIMEOUT);
> {code}
> It works now because both DEFAULT_READ_TIMEOUT and STALLED_COPY_TIMEOUT have the same value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4732) connectionTimeout and readTimeout
are passed in wrong order in ReduceTask.java
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-4732:
--------------------------------------------
Attachment: patch-4732.txt
Patch fixing it.
> connectionTimeout and readTimeout are passed in wrong order in ReduceTask.java
> -------------------------------------------------------------------------------
>
> Key: HADOOP-4732
> URL: https://issues.apache.org/jira/browse/HADOOP-4732
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: patch-4732.txt
>
>
> In ReduceTask.java, The parameters for method calls for getInputStream(URLConnection connection, int connectionTimeout, int readTimeout) should be in that order. Now it is
> {code}
> InputStream input = getInputStream(connection, DEFAULT_READ_TIMEOUT,
> STALLED_COPY_TIMEOUT);
> {code}
> It works now because both DEFAULT_READ_TIMEOUT and STALLED_COPY_TIMEOUT have the same value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.