You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/25 13:38:57 UTC

[GitHub] [beam] lazylynx commented on a change in pull request #14292: [BEAM-7372] remove codepath and workaround for py2 from io

lazylynx commented on a change in pull request #14292:
URL: https://github.com/apache/beam/pull/14292#discussion_r601492980



##########
File path: sdks/python/apache_beam/io/gcp/bigquery_avro_tools_test.py
##########
@@ -90,9 +86,7 @@ def test_convert_bigquery_schema_to_avro_schema(self):
 
     # Test that schema can be parsed correctly by avro
     parsed_schema = Parse(json.dumps(avro_schema))
-    # Avro RecordSchema provides field_map in py3 and fields_dict in py2
-    field_map = getattr(parsed_schema, "field_map", None) or \
-      getattr(parsed_schema, "fields_dict", None)
+    field_map = getattr(parsed_schema, "field_map", None)

Review comment:
       Updated




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org