You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by hmcl <gi...@git.apache.org> on 2017/10/29 23:11:07 UTC

[GitHub] storm pull request #2393: STORM-2781: Refactor storm-kafka-client KafkaSpout...

GitHub user hmcl opened a pull request:

    https://github.com/apache/storm/pull/2393

    STORM-2781: Refactor storm-kafka-client KafkaSpout Processing Guarantees

     - Define processing guarantees as AT_LEAST_ONCE, AT_MOST_ONCE, NONE
     - Refactor method name from setForceEnableTupleTracking to setTupleTrackingEnforced
     - Throw IllegalStateException instead of IllegalArgumentException if spout attempts to emit an already committed message
     - Update documentation to reflect these changes

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hmcl/storm-apache 1.x-branch_STORM-2781_KSProcGtees

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2393.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2393
    
----
commit ac16fe1ee9d974af64a30769819561c0abae23af
Author: Hugo Louro <hm...@gmail.com>
Date:   2017-10-23T00:44:54Z

    STORM-2781: Refactor storm-kafka-client KafkaSpout Processing Guarantees
    
     - Define processing guarantees as AT_LEAST_ONCE, AT_MOST_ONCE, NONE
     - Refactor method name from setForceEnableTupleTracking to setTupleTrackingEnforced
     - Throw IllegalStateException instead of IllegalArgumentException if spout attempts to emit an already committed message
     - Update documentation to reflect these changes

----


---

[GitHub] storm issue #2393: STORM-2781: Refactor storm-kafka-client KafkaSpout Proces...

Posted by hmcl <gi...@git.apache.org>.

Github user hmcl commented on the issue:

    https://github.com/apache/storm/pull/2393
  
    @HeartSaVioR for 1.x-branch


---

[GitHub] storm issue #2393: STORM-2781: Refactor storm-kafka-client KafkaSpout Proces...

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2393
  
    +1 (I missed it.)


---

[GitHub] storm pull request #2393: STORM-2781: Refactor storm-kafka-client KafkaSpout...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2393


---