You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/11/05 02:35:11 UTC
[GitHub] [tvm] zxybazh opened a new pull request #9451: [BugFix] Fix Infinite Loop Caused When Calling Methods Not Overrided In PyClass.
zxybazh opened a new pull request #9451:
URL: https://github.com/apache/tvm/pull/9451
This patch fixes the infinite loop when you call a PyClass's undefined method. Now that we defined a new helper function decorator `check_override` and it would make sure a not implemented error would be thrown if the method has no default implementation. And it could still leverage default implementation for methods on the c++ side as shown in `test_meta_schedule_task_scheduler.py::test_meta_schedule_task_scheduler_override_next_task_id_only` test case.
To summarize:
1. It fixed a infinite loop bug.
2. It enables PyClasses to define only methods required to implement.
3. It throws `NotImplementError` early when a class with any required function is missing.
4. It fixes the constructor of task scheduler and enhances its unittests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9451: [Bug][Meta Schedule] Fix Infinite Loop Caused When Calling Methods Not Overrided In PyClass.
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9451:
URL: https://github.com/apache/tvm/pull/9451#issuecomment-962150329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9451: [Bug][Meta Schedule] Fix Infinite Loop Caused When Calling Methods Not Overrided In PyClass.
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9451:
URL: https://github.com/apache/tvm/pull/9451#issuecomment-962150329
Oh my spell checker just reminded by that we should "overridden" is the correct word 🤦♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 merged pull request #9451: [Bug][Meta Schedule] Fix Infinite Loop Caused When Calling Methods Not Overrided In PyClass.
Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #9451:
URL: https://github.com/apache/tvm/pull/9451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 merged pull request #9451: [Bug][Meta Schedule] Fix Infinite Loop Caused When Calling Methods Not Overrided In PyClass.
Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #9451:
URL: https://github.com/apache/tvm/pull/9451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org