[GitHub] [hudi] XuQianJin-Stars commented on a diff in pull request #5957: [HUDI-4315] Do not throw exception in BaseSpark3Adapter#toTableIdentifier

[GitBox <gi...@apache.org>]

XuQianJin-Stars commented on code in PR #5957:
URL: https://github.com/apache/hudi/pull/5957#discussion_r906741772


##########
hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/adapter/BaseSpark3Adapter.scala:
##########
@@ -115,7 +115,12 @@ abstract class BaseSpark3Adapter extends SparkAdapter {
     unfoldSubqueryAliases(table) match {
       case LogicalRelation(_, _, Some(table), _) => isHoodieTable(table)
       case relation: UnresolvedRelation =>
-        isHoodieTable(toTableIdentifier(relation), spark)
+        try {
+          isHoodieTable(toTableIdentifier(relation), spark)
+        } catch {
+          case NonFatal(_) =>
+            false

Review Comment:
   Add log warn printing to facilitate troubleshooting?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org