You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/02 02:23:52 UTC
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #2320: feat: support protobuf on Web
LiteSun commented on a change in pull request #2320:
URL: https://github.com/apache/apisix-dashboard/pull/2320#discussion_r817295120
##########
File path: web/src/pages/Proto/components/ProtoDrawer/index.less
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+@import '~antd/es/style/themes/default.less';
+
+.formItemEditor {
+ flex-flow: column;
+ row-gap: 20px !important;
Review comment:
not recommend using !important here
##########
File path: web/cypress/integration/proto/create_and_edit_and_delete_proto.spce.js
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/* eslint-disable no-undef */
+
+context('Create and Delete Proto', () => {
+ const selector = {
+ id: '#id',
+ description: '#desc',
+ content: '.view-lines',
+ draw: '.ant-drawer-content',
+ notification: '.ant-notification-notice-message',
+ };
+
+ const data = {
+ id: 'test_id',
+ description: 'test_description',
+ content: `message Person {
+required string name = 1;
+required int32 id = 2;
+optional string email = 3;
+}`,
+ description2: 'test_description2',
+ content2: `message Person2 {
+required string name = 1;
+required int32 id = 2;
+optional string email = 3;
+}`,
+ createProtoSuccess: 'Create proto Successfully',
+ configureProtoSuccess: 'Configure proto Successfully',
+ deleteProtoDelete: 'Delete Upstream Successfully',
+ };
+
+ beforeEach(() => {
+ cy.login();
+ });
+
+ it('should create proto', () => {
+ cy.visit('/');
+ cy.contains('Proto').click();
+ cy.contains('Create').click();
+ cy.get(selector.draw)
+ .should('be.visible')
+ .within(() => {
+ cy.get(selector.id).type(data.id);
+ cy.get(selector.description).type(data.description);
+ cy.get(selector.content).type(data.content);
+
+ cy.contains('Submit').click();
+ });
+ cy.get(selector.notification).should('contain', data.createProtoSuccess);
+ });
+
+ it('should edit the proto', () => {
+ cy.visit('/');
+ cy.contains('Proto').click();
+ cy.contains(data.id).siblings().contains('Configure').click();
+ cy.get(selector.draw)
+ .should('be.visible')
+ .within(() => {
+ cy.get(selector.description).clear().type(data.description2);
+ cy.get(selector.content).type(data.content2);
+
+ cy.contains('Submit').click();
+ });
+ cy.get(selector.notification).should('contain', data.configureProtoSuccess);
Review comment:
After verifying notification displays correct text as expected, it would be better to close the notification component, or it may cause test unstable.
##########
File path: web/cypress/integration/proto/create_and_edit_and_delete_proto.spce.js
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/* eslint-disable no-undef */
+
+context('Create and Delete Proto', () => {
+ const selector = {
+ id: '#id',
+ description: '#desc',
+ content: '.view-lines',
+ draw: '.ant-drawer-content',
+ notification: '.ant-notification-notice-message',
+ };
+
+ const data = {
+ id: 'test_id',
+ description: 'test_description',
+ content: `message Person {
+required string name = 1;
+required int32 id = 2;
+optional string email = 3;
+}`,
+ description2: 'test_description2',
+ content2: `message Person2 {
+required string name = 1;
+required int32 id = 2;
+optional string email = 3;
+}`,
+ createProtoSuccess: 'Create proto Successfully',
+ configureProtoSuccess: 'Configure proto Successfully',
+ deleteProtoDelete: 'Delete Upstream Successfully',
+ };
+
+ beforeEach(() => {
+ cy.login();
+ });
+
+ it('should create proto', () => {
+ cy.visit('/');
+ cy.contains('Proto').click();
+ cy.contains('Create').click();
+ cy.get(selector.draw)
+ .should('be.visible')
+ .within(() => {
+ cy.get(selector.id).type(data.id);
+ cy.get(selector.description).type(data.description);
+ cy.get(selector.content).type(data.content);
+
+ cy.contains('Submit').click();
+ });
+ cy.get(selector.notification).should('contain', data.createProtoSuccess);
+ });
+
+ it('should edit the proto', () => {
+ cy.visit('/');
+ cy.contains('Proto').click();
+ cy.contains(data.id).siblings().contains('Configure').click();
+ cy.get(selector.draw)
+ .should('be.visible')
+ .within(() => {
+ cy.get(selector.description).clear().type(data.description2);
+ cy.get(selector.content).type(data.content2);
+
+ cy.contains('Submit').click();
+ });
+ cy.get(selector.notification).should('contain', data.configureProtoSuccess);
+ });
+
+ it('should delete the proto', () => {
+ cy.visit('/');
+ cy.contains('Proto').click();
+ cy.contains(data.id).siblings().contains('Delete').click();
+ cy.contains('button', 'Confirm').click();
+ cy.get(selector.notification).should('contain', data.deleteProtoDelete);
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org