[GitHub] [tvm] Lunderberg commented on pull request #8873: [UnitTests][Ethos-N] Mark unit tests as requiring Ethos-N

[GitBox <gi...@apache.org>]

Lunderberg commented on pull request #8873:
URL: https://github.com/apache/tvm/pull/8873#issuecomment-910354261


   > @Mousius: Thanks for this @Lunderberg, I was just curious whether we should have a tvm.testing.contrib ? Personally, I would rather have it as it is here, and it's an improvement either way smile_cat
   
   I think I'd lean toward having it here.  If some of the tools in contrib require a lot of testing functionality, then I think it would make sense to break it out, but so far it's only been single functions here and there.
   
   > @leandron: In general LGTM. I remembered we have another test that can be marked with this new decorator, in tvmc.
   
   Thank you for pointing that out, and I've updated it as well.  A quick grep doesn't show any other folders that reference ethosn, so we should be set there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org