You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/12 21:22:30 UTC
[GitHub] [airflow] ashb opened a new pull request #9256: Update (previously null) imap_default conn_type
ashb opened a new pull request #9256:
URL: https://github.com/apache/airflow/pull/9256
This is a test fixup to #9187, and updates the possibly existing
imap_default connection, and adds that hook type to the various lists
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] feluelle commented on pull request #9256: Update (previously null) imap_default conn_type
Posted by GitBox <gi...@apache.org>.
feluelle commented on pull request #9256:
URL: https://github.com/apache/airflow/pull/9256#issuecomment-643492796
> @feluelle with conn_type now being required column (and us not noticing this was a problem cos test weren't passing) it became waay more urgent :)
I knew of the unique conn_type change but didn't know we merged the related PR already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #9256: Update (previously null) imap_default conn_type
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #9256:
URL: https://github.com/apache/airflow/pull/9256
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #9256: Update (previously null) imap_default conn_type
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #9256:
URL: https://github.com/apache/airflow/pull/9256#issuecomment-643491738
@feluelle with conn_type now being required column (and us not noticing this was a problem cos test weren't passing) it became waay more urgent :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org