You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/09 21:43:34 UTC

[GitHub] [airflow] darwinyip opened a new issue #12214: SlackWebhookHook should use password instead of extra to store the token

darwinyip opened a new issue #12214:
URL: https://github.com/apache/airflow/issues/12214


   Currently `SlackWebhookHook` gets the token from `extra` but it would be more secure and intuitive to have it in password.
   
   https://github.com/apache/airflow/blob/4fb5c017fe5ca41ed95547a857c9c39efc4f1476/airflow/providers/slack/hooks/slack_webhook.py


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on issue #12214: SlackWebhookHook should use password instead of extra to store the token

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #12214:
URL: https://github.com/apache/airflow/issues/12214#issuecomment-724389739


   Sound good to me. Can I assign you to this ticket?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj edited a comment on issue #12214: SlackWebhookHook should use password instead of extra to store the token

Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #12214:
URL: https://github.com/apache/airflow/issues/12214#issuecomment-725022976






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] darwinyip commented on issue #12214: SlackWebhookHook should use password instead of extra to store the token

Posted by GitBox <gi...@apache.org>.
darwinyip commented on issue #12214:
URL: https://github.com/apache/airflow/issues/12214#issuecomment-725022145


   @mik-laj Sure! Do I need to make it backwards compatible and support extra along with password?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on issue #12214: SlackWebhookHook should use password instead of extra to store the token

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #12214:
URL: https://github.com/apache/airflow/issues/12214#issuecomment-725022976


   Yes. You should also add [DeprecationWarning](https://github.com/apache/airflow/search?q=DeprecationWarning). I assigned you to this ticket.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil closed issue #12214: SlackWebhookHook should use password instead of extra to store the token

Posted by GitBox <gi...@apache.org>.
kaxil closed issue #12214:
URL: https://github.com/apache/airflow/issues/12214


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj edited a comment on issue #12214: SlackWebhookHook should use password instead of extra to store the token

Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #12214:
URL: https://github.com/apache/airflow/issues/12214#issuecomment-724389739


   Sound good to me. Can I assign you to this ticket? I'm happy to help with review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org