You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "etseidl (via GitHub)" <gi...@apache.org> on 2026/08/05 23:21:50 UTC
[PR] parquet: Remove deprecated functions [arrow-rs]
etseidl opened a new pull request, #10565:
URL: https://github.com/apache/arrow-rs/pull/10565
# Which issue does this PR close?
N/A
# Rationale for this change
Remove deprecated functions from the public API.
# What changes are included in this PR?
Removed functions and tests that used them.
# Are these changes tested?
Covered by existing tests
# Are there any user-facing changes?
Yes, removes functions from the public API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] parquet: Remove deprecated functions [arrow-rs]
Posted by "etseidl (via GitHub)" <gi...@apache.org>.
etseidl merged PR #10565:
URL: https://github.com/apache/arrow-rs/pull/10565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] parquet: Remove deprecated functions [arrow-rs]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on code in PR #10565:
URL: https://github.com/apache/arrow-rs/pull/10565#discussion_r3725292144
##########
parquet/src/file/properties.rs:
##########
@@ -350,14 +350,6 @@ impl WriterProperties {
self.write_batch_size
}
- /// Returns maximum number of rows in a row group, or `usize::MAX` if unlimited.
- ///
- /// For more details see [`WriterPropertiesBuilder::set_max_row_group_size`]
- #[deprecated(since = "58.0.0", note = "Use `max_row_group_row_count` instead")]
Review Comment:
would this be too soon according to our policy?
https://github.com/apache/arrow-rs/blob/6b7d6b3279ba4b4925e43bfc9b8a266fcf1660ad/README.md?plain=1#L145-L149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] parquet: Remove deprecated functions [arrow-rs]
Posted by "etseidl (via GitHub)" <gi...@apache.org>.
etseidl commented on code in PR #10565:
URL: https://github.com/apache/arrow-rs/pull/10565#discussion_r3725338121
##########
parquet/src/file/properties.rs:
##########
@@ -350,14 +350,6 @@ impl WriterProperties {
self.write_batch_size
}
- /// Returns maximum number of rows in a row group, or `usize::MAX` if unlimited.
- ///
- /// For more details see [`WriterPropertiesBuilder::set_max_row_group_size`]
- #[deprecated(since = "58.0.0", note = "Use `max_row_group_row_count` instead")]
Review Comment:
Since it's 58.0, it has been deprecated for two full releases (6 months). I think it's fair game 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] parquet: Remove deprecated functions [arrow-rs]
Posted by "etseidl (via GitHub)" <gi...@apache.org>.
etseidl commented on PR #10565:
URL: https://github.com/apache/arrow-rs/pull/10565#issuecomment-5208571989
Thanks for the review @Jefffrey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org