You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Chaoyu Tang <ct...@gmail.com> on 2015/11/05 14:59:43 UTC
Review Request 39973: HIVE-12346: Internally used variables in
HiveConf should not be settable via command
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39973/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-12346
https://issues.apache.org/jira/browse/HIVE-12346
Repository: hive-git
Description
-------
Internally used variables are put in a HiveConf HIVE_CONF_INTERNAL_VARIABLE_LIST, which is a part of restricted list.
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3ab73ad
ql/src/test/queries/clientnegative/set_hiveconf_internal_variable0.q PRE-CREATION
ql/src/test/queries/clientnegative/set_hiveconf_internal_variable1.q PRE-CREATION
ql/src/test/results/clientnegative/set_hiveconf_internal_variable0.q.out PRE-CREATION
ql/src/test/results/clientnegative/set_hiveconf_internal_variable1.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/39973/diff/
Testing
-------
New qtests passed
Running precommit build
Thanks,
Chaoyu Tang
Re: Review Request 39973: HIVE-12346: Internally used variables in
HiveConf should not be settable via command
Posted by Chaoyu Tang <ct...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39973/
-----------------------------------------------------------
(Updated Nov. 5, 2015, 11:27 p.m.)
Review request for hive.
Changes
-------
Revise patch based on review.
Bugs: HIVE-12346
https://issues.apache.org/jira/browse/HIVE-12346
Repository: hive-git
Description
-------
Internally used variables are put in a HiveConf HIVE_CONF_INTERNAL_VARIABLE_LIST, which is a part of restricted list.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3ab73ad
ql/src/test/queries/clientnegative/set_hiveconf_internal_variable0.q PRE-CREATION
ql/src/test/queries/clientnegative/set_hiveconf_internal_variable1.q PRE-CREATION
ql/src/test/results/clientnegative/set_hiveconf_internal_variable0.q.out PRE-CREATION
ql/src/test/results/clientnegative/set_hiveconf_internal_variable1.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/39973/diff/
Testing
-------
New qtests passed
Running precommit build
Thanks,
Chaoyu Tang
Re: Review Request 39973: HIVE-12346: Internally used variables in
HiveConf should not be settable via command
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39973/#review105242
-----------------------------------------------------------
Ship it!
Ship It!
- Xuefu Zhang
On Nov. 5, 2015, 1:59 p.m., Chaoyu Tang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39973/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2015, 1:59 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-12346
> https://issues.apache.org/jira/browse/HIVE-12346
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Internally used variables are put in a HiveConf HIVE_CONF_INTERNAL_VARIABLE_LIST, which is a part of restricted list.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3ab73ad
> ql/src/test/queries/clientnegative/set_hiveconf_internal_variable0.q PRE-CREATION
> ql/src/test/queries/clientnegative/set_hiveconf_internal_variable1.q PRE-CREATION
> ql/src/test/results/clientnegative/set_hiveconf_internal_variable0.q.out PRE-CREATION
> ql/src/test/results/clientnegative/set_hiveconf_internal_variable1.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39973/diff/
>
>
> Testing
> -------
>
> New qtests passed
> Running precommit build
>
>
> Thanks,
>
> Chaoyu Tang
>
>