You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by el...@apache.org on 2016/11/27 10:41:26 UTC
svn commit: r1771555 - in /directory/shared/branches/shared-value/ldap/extras/trigger/src/main/java/org/apache/directory/api/ldap/trigger: LdapOperation.java StoredProcedureParameter.java TriggerSpecification.java

Author: elecharny
Date: Sun Nov 27 10:41:26 2016
New Revision: 1771555

URL: http://svn.apache.org/viewvc?rev=1771555&view=rev
Log:
Fixed Sonarlint warnings

Modified:
    directory/shared/branches/shared-value/ldap/extras/trigger/src/main/java/org/apache/directory/api/ldap/trigger/LdapOperation.java
    directory/shared/branches/shared-value/ldap/extras/trigger/src/main/java/org/apache/directory/api/ldap/trigger/StoredProcedureParameter.java
    directory/shared/branches/shared-value/ldap/extras/trigger/src/main/java/org/apache/directory/api/ldap/trigger/TriggerSpecification.java

Modified: directory/shared/branches/shared-value/ldap/extras/trigger/src/main/java/org/apache/directory/api/ldap/trigger/LdapOperation.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/extras/trigger/src/main/java/org/apache/directory/api/ldap/trigger/LdapOperation.java?rev=1771555&r1=1771554&r2=1771555&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/extras/trigger/src/main/java/org/apache/directory/api/ldap/trigger/LdapOperation.java (original)
+++ directory/shared/branches/shared-value/ldap/extras/trigger/src/main/java/org/apache/directory/api/ldap/trigger/LdapOperation.java Sun Nov 27 10:41:26 2016
@@ -66,6 +66,10 @@ public enum LdapOperation
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
+    @Override
     public String toString()
     {
         return name;

Modified: directory/shared/branches/shared-value/ldap/extras/trigger/src/main/java/org/apache/directory/api/ldap/trigger/StoredProcedureParameter.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/extras/trigger/src/main/java/org/apache/directory/api/ldap/trigger/StoredProcedureParameter.java?rev=1771555&r1=1771554&r2=1771555&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/extras/trigger/src/main/java/org/apache/directory/api/ldap/trigger/StoredProcedureParameter.java (original)
+++ directory/shared/branches/shared-value/ldap/extras/trigger/src/main/java/org/apache/directory/api/ldap/trigger/StoredProcedureParameter.java Sun Nov 27 10:41:26 2016
@@ -55,6 +55,7 @@ public abstract class StoredProcedurePar
         }
 
 
+        @Override
         public String toString()
         {
             return name + " \"" + ctxName.getName() + "\"";
@@ -96,6 +97,7 @@ public abstract class StoredProcedurePar
     }
 
 
+    @Override
     public String toString()
     {
         return name;
@@ -106,6 +108,7 @@ public abstract class StoredProcedurePar
      * @see java.lang.Object#hashCode()
      * @return the instance's hash code 
      */
+    @Override
     public int hashCode()
     {
         int h = 37;
@@ -119,6 +122,7 @@ public abstract class StoredProcedurePar
     /**
      * @see java.lang.Object#equals(java.lang.Object)
      */
+    @Override
     public boolean equals( Object obj )
     {
         if ( this == obj )

Modified: directory/shared/branches/shared-value/ldap/extras/trigger/src/main/java/org/apache/directory/api/ldap/trigger/TriggerSpecification.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/extras/trigger/src/main/java/org/apache/directory/api/ldap/trigger/TriggerSpecification.java?rev=1771555&r1=1771554&r2=1771555&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/extras/trigger/src/main/java/org/apache/directory/api/ldap/trigger/TriggerSpecification.java (original)
+++ directory/shared/branches/shared-value/ldap/extras/trigger/src/main/java/org/apache/directory/api/ldap/trigger/TriggerSpecification.java Sun Nov 27 10:41:26 2016
@@ -52,16 +52,17 @@ public class TriggerSpecification
     public TriggerSpecification( LdapOperation ldapOperation, ActionTime actionTime, List<SPSpec> spSpecs )
     {
         super();
-        if ( ldapOperation == null
-            || actionTime == null
-            || spSpecs == null )
+        
+        if ( ( ldapOperation == null ) || ( actionTime == null ) || ( spSpecs == null ) )
         {
             throw new NullArgumentException( I18n.err( I18n.ERR_04331 ) );
         }
-        if ( spSpecs.size() == 0 )
+        
+        if ( spSpecs.isEmpty() )
         {
             throw new IllegalArgumentException( I18n.err( I18n.ERR_04332 ) );
         }
+        
         this.ldapOperation = ldapOperation;
         this.actionTime = actionTime;
         this.spSpecs = spSpecs;